diff options
author | Jason Molenda <jmolenda@apple.com> | 2012-10-04 22:47:07 +0000 |
---|---|---|
committer | Jason Molenda <jmolenda@apple.com> | 2012-10-04 22:47:07 +0000 |
commit | ccd41e55f1cd1a2a99bd357076638954f419429a (patch) | |
tree | 7093042eeeef422e29e4448976973272005341ca /lldb/source/API/SBDebugger.cpp | |
parent | bfeb28087ae76b6c241a6dc1727429fe8f6f76a7 (diff) | |
download | bcm5719-llvm-ccd41e55f1cd1a2a99bd357076638954f419429a.tar.gz bcm5719-llvm-ccd41e55f1cd1a2a99bd357076638954f419429a.zip |
Ran the sources through the compiler with -Wshadow warnings
enabled after we'd found a few bugs that were caused by shadowed
local variables; the most important issue this turned up was
a common mistake of trying to obtain a mutex lock for the scope
of a code block by doing
Mutex::Locker(m_map_mutex);
This doesn't assign the lock object to a local variable; it is
a temporary that has its dtor called immediately. Instead,
Mutex::Locker locker(m_map_mutex);
does what is intended. For some reason -Wshadow happened to
highlight these as shadowed variables.
I also fixed a few obivous and easy shadowed variable issues
across the code base but there are a couple dozen more that
should be fixed when someone has a free minute.
<rdar://problem/12437585>
llvm-svn: 165269
Diffstat (limited to 'lldb/source/API/SBDebugger.cpp')
-rw-r--r-- | lldb/source/API/SBDebugger.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/lldb/source/API/SBDebugger.cpp b/lldb/source/API/SBDebugger.cpp index ca39d2a80d6..3540b28a64c 100644 --- a/lldb/source/API/SBDebugger.cpp +++ b/lldb/source/API/SBDebugger.cpp @@ -555,7 +555,6 @@ SBDebugger::CreateTargetWithFileAndTargetTriple (const char *filename, if (m_opaque_sp) { FileSpec file_spec (filename, true); - TargetSP target_sp; const bool add_dependent_modules = true; Error error (m_opaque_sp->GetTargetList().CreateTarget (*m_opaque_sp, file_spec, |