Improved the packet throughput when debugging with GDB remote by over 3x on

darwin (not sure about other platforms).

Modified the communication and connection classes to not require the
BytesAvailable function. Now the "Read(...)" function has a timeout in
microseconds.

Fixed a lot of assertions that were firing off in certain cases and replaced
them with error output and code that can deal with the assertion case.

llvm-svn: 133224

1 files changed, 0 insertions, 24 deletions

diff --git a/lldb/source/API/SBCommunication.cpp b/lldb/source/API/SBCommunication.cpp
index 9db6c444902..160640683d1 100644
--- a/lldb/source/API/SBCommunication.cpp
+++ b/lldb/source/API/SBCommunication.cpp
@@ -59,30 +59,6 @@ SBCommunication::SetCloseOnEOF (bool b)
 }
 
 ConnectionStatus
-SBCommunication::CheckIfBytesAvailable ()
-{
-    if (m_opaque)
-        return m_opaque->BytesAvailable (0, NULL);
-    return eConnectionStatusNoConnection;
-}
-
-ConnectionStatus
-SBCommunication::WaitForBytesAvailableInfinite ()
-{
-    if (m_opaque)
-        return m_opaque->BytesAvailable (UINT32_MAX, NULL);
-    return eConnectionStatusNoConnection;
-}
-
-ConnectionStatus
-SBCommunication::WaitForBytesAvailableWithTimeout (uint32_t timeout_usec)
-{
-    if (m_opaque)
-        return m_opaque->BytesAvailable (timeout_usec, NULL);
-    return eConnectionStatusNoConnection;
-}
-
-ConnectionStatus
 SBCommunication::Connect (const char *url)
 {
     if (m_opaque)