diff options
| author | Alex Langford <apl@fb.com> | 2018-07-27 19:41:17 +0000 |
|---|---|---|
| committer | Alex Langford <apl@fb.com> | 2018-07-27 19:41:17 +0000 |
| commit | c1d4311c1b2c9adaa9b28e2e5316fd02171e17a2 (patch) | |
| tree | f7d4f241a191ccede03550aaf2e107e39ea67efa /lldb/source/API/CMakeLists.txt | |
| parent | e6c78eafdedfa419d72bc978d124d14bef56ff8e (diff) | |
| download | bcm5719-llvm-c1d4311c1b2c9adaa9b28e2e5316fd02171e17a2.tar.gz bcm5719-llvm-c1d4311c1b2c9adaa9b28e2e5316fd02171e17a2.zip | |
Stop building liblldb with CMake's framework functionality
Summary:
CMake has a bug in its ninja generator that prevents you from
installing targets that are built with framework support. Therefore, I want to
not rely on CMake's framework support.
See https://gitlab.kitware.com/cmake/cmake/issues/18216
Differential Revision: https://reviews.llvm.org/D49888
llvm-svn: 338154
Diffstat (limited to 'lldb/source/API/CMakeLists.txt')
| -rw-r--r-- | lldb/source/API/CMakeLists.txt | 23 |
1 files changed, 14 insertions, 9 deletions
diff --git a/lldb/source/API/CMakeLists.txt b/lldb/source/API/CMakeLists.txt index be9d4115cec..4032332ad08 100644 --- a/lldb/source/API/CMakeLists.txt +++ b/lldb/source/API/CMakeLists.txt @@ -110,10 +110,20 @@ if (LLVM_COMPILER_IS_GCC_COMPATIBLE AND PROPERTY COMPILE_FLAGS " -Wno-sequence-point -Wno-cast-qual") endif () -set_target_properties(liblldb - PROPERTIES - VERSION ${LLDB_VERSION} -) +if (LLDB_BUILD_FRAMEWORK) + set_target_properties(liblldb + PROPERTIES + LIBRARY_OUTPUT_DIRECTORY ${LLDB_FRAMEWORK_DIR}/Versions/${LLDB_FRAMEWORK_VERSION} + PREFIX "" + SUFFIX "" + INSTALL_NAME_DIR "@rpath/LLDB.framework" + OUTPUT_NAME LLDB) +else() + set_target_properties(liblldb + PROPERTIES + VERSION ${LLDB_VERSION} + OUTPUT_NAME lldb) +endif() if (NOT CMAKE_SYSTEM_NAME MATCHES "Windows") if (NOT LLDB_EXPORT_ALL_SYMBOLS) @@ -136,11 +146,6 @@ if ( CMAKE_SYSTEM_NAME MATCHES "Windows" ) if (MSVC AND NOT LLDB_DISABLE_PYTHON) target_link_libraries(liblldb PRIVATE ${PYTHON_LIBRARY}) endif() -else() - set_target_properties(liblldb - PROPERTIES - OUTPUT_NAME lldb - ) endif() if (LLDB_WRAP_PYTHON) |
