I had recently added a new SBFrame::GetVariables() overload with yet another bool argument

We talked about it internally - and came to the conclusion that it's time to have an options class

This commit adds an SBVariablesOptions class and goes through all the required dance

llvm-svn: 228975

3 files changed, 64 insertions, 6 deletions

diff --git a/lldb/scripts/Python/build-swig-Python.sh b/lldb/scripts/Python/build-swig-Python.sh
index 37dffb15ea4..457e905ffba 100755
--- a/lldb/scripts/Python/build-swig-Python.sh
+++ b/lldb/scripts/Python/build-swig-Python.sh
@@ -126,6 +126,7 @@ HEADER_FILES="${SRC_ROOT}/include/lldb/lldb.h"\
 " ${SRC_ROOT}/include/lldb/API/SBTypeSynthetic.h"\
 " ${SRC_ROOT}/include/lldb/API/SBValue.h"\
 " ${SRC_ROOT}/include/lldb/API/SBValueList.h"\
+" ${SRC_ROOT}/include/lldb/API/SBVariablesOptions.h"\
 " ${SRC_ROOT}/include/lldb/API/SBWatchpoint.h"\
 " ${SRC_ROOT}/include/lldb/API/SBUnixSignals.h"
 
@@ -178,6 +179,7 @@ INTERFACE_FILES="${SRC_ROOT}/scripts/Python/interface/SBAddress.i"\
 " ${SRC_ROOT}/scripts/Python/interface/SBTypeSynthetic.i"\
 " ${SRC_ROOT}/scripts/Python/interface/SBValue.i"\
 " ${SRC_ROOT}/scripts/Python/interface/SBValueList.i"\
+" ${SRC_ROOT}/scripts/Python/interface/SBVariablesOptions.i"\
 " ${SRC_ROOT}/scripts/Python/interface/SBWatchpoint.i"\
 " ${SRC_ROOT}/scripts/Python/interface/SBUnixSignals.i"
 
diff --git a/lldb/scripts/Python/interface/SBFrame.i b/lldb/scripts/Python/interface/SBFrame.i
index 5cacb5ea1b3..b1d1e4e9215 100644
--- a/lldb/scripts/Python/interface/SBFrame.i
+++ b/lldb/scripts/Python/interface/SBFrame.i
@@ -199,12 +199,7 @@ public:
                   lldb::DynamicValueType  use_dynamic);
 
     lldb::SBValueList
-    GetVariables (bool arguments,
-                  bool locals,
-                  bool statics,
-                  bool in_scope_only,
-                  bool include_runtime_support_values,
-                  lldb::DynamicValueType  use_dynamic);
+    GetVariables (const lldb::SBVariablesOptions& options);
              
     lldb::SBValueList
     GetRegisters ();
diff --git a/lldb/scripts/Python/interface/SBVariablesOptions.i b/lldb/scripts/Python/interface/SBVariablesOptions.i
new file mode 100644
index 00000000000..3941a58d7bc
--- /dev/null
+++ b/lldb/scripts/Python/interface/SBVariablesOptions.i
@@ -0,0 +1,61 @@
+//===-- SWIG Interface for SBVariablesOptions ----------------------*- C++ -*-===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+
+namespace lldb {
+    
+class SBVariablesOptions
+{
+public:
+    SBVariablesOptions ();
+    
+    SBVariablesOptions (const SBVariablesOptions& options);
+    
+    ~SBVariablesOptions ();
+    
+    bool
+    IsValid () const;
+    
+    bool
+    GetIncludeArguments ()  const;
+    
+    void
+    SetIncludeArguments (bool);
+    
+    bool
+    GetIncludeLocals ()  const;
+    
+    void
+    SetIncludeLocals (bool);
+    
+    bool
+    GetIncludeStatics ()  const;
+    
+    void
+    SetIncludeStatics (bool);
+    
+    bool
+    GetInScopeOnly ()  const;
+    
+    void
+    SetInScopeOnly (bool);
+    
+    bool
+    GetIncludeRuntimeSupportValues () const;
+    
+    void
+    SetIncludeRuntimeSupportValues (bool);
+    
+    lldb::DynamicValueType
+    GetUseDynamic () const;
+    
+    void
+    SetUseDynamic (lldb::DynamicValueType);
+};
+    
+} // namespace lldb