Revert "[lldb] Use vFlash commands when writing to target's flash memory regions"

This reverts commit r326261 as it introduces inconsistencies in the
handling of load addresses for ObjectFileELF -- some parts of the class
use physical addresses, and some use virtual. This has manifested itself
as us not being able to set the load address of the vdso "module" on
android.

llvm-svn: 326367

1 files changed, 0 insertions, 61 deletions

diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteLoad.py b/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteLoad.py
deleted file mode 100644
index cce19a3bfa7..00000000000
--- a/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteLoad.py
+++ /dev/null
@@ -1,61 +0,0 @@
-import lldb
-from lldbsuite.test.lldbtest import *
-from lldbsuite.test.decorators import *
-from gdbclientutils import *
-
-
-class TestGDBRemoteLoad(GDBRemoteTestBase):
-
-    def test_ram_load(self):
-        """Test loading an object file to a target's ram"""
-        target = self.createTarget("a.yaml")
-        process = self.connect(target)
-        self.dbg.HandleCommand("target modules load -l -s0")
-        self.assertPacketLogContains([
-                "M1000,4:c3c3c3c3",
-                "M1004,2:3232"
-                ])
-
-    @skipIfXmlSupportMissing
-    def test_flash_load(self):
-        """Test loading an object file to a target's flash memory"""
-
-        class Responder(MockGDBServerResponder):
-            def qSupported(self, client_supported):
-                return "PacketSize=3fff;QStartNoAckMode+;qXfer:memory-map:read+"
-
-            def qXferRead(self, obj, annex, offset, length):
-                if obj == "memory-map":
-                    return (self.MEMORY_MAP[offset:offset + length],
-                            offset + length < len(self.MEMORY_MAP))
-                return None, False
-
-            def other(self, packet):
-                if packet[0:11] == "vFlashErase":
-                    return "OK"
-                if packet[0:11] == "vFlashWrite":
-                    return "OK"
-                if packet == "vFlashDone":
-                    return "OK"
-                return ""
-
-            MEMORY_MAP = """<?xml version="1.0"?>
-<memory-map>
-  <memory type="ram" start="0x0" length="0x1000"/>
-  <memory type="flash" start="0x1000" length="0x1000">
-    <property name="blocksize">0x100</property>
-  </memory>
-  <memory type="ram" start="0x2000" length="0x1D400"/>
-</memory-map>
-"""
-
-        self.server.responder = Responder()
-        target = self.createTarget("a.yaml")
-        process = self.connect(target)
-        self.dbg.HandleCommand("target modules load -l -s0")
-        self.assertPacketLogContains([
-                "vFlashErase:1000,100",
-                "vFlashWrite:1000:\xc3\xc3\xc3\xc3",
-                "vFlashWrite:1004:\x32\x32",
-                "vFlashDone"
-                ])