diff options
| author | Raphael Isemann <teemperor@gmail.com> | 2020-01-02 14:46:39 +0100 |
|---|---|---|
| committer | Raphael Isemann <teemperor@gmail.com> | 2020-01-02 14:47:04 +0100 |
| commit | 7ead00872929a994ac40fc2c99fce15968e2c5a6 (patch) | |
| tree | a5a52a72d985b676793b20158c3e1cc811a79f3b /lldb/packages/Python | |
| parent | 136f34fed661869ebb0082d32f7b5399baca204c (diff) | |
| download | bcm5719-llvm-7ead00872929a994ac40fc2c99fce15968e2c5a6.tar.gz bcm5719-llvm-7ead00872929a994ac40fc2c99fce15968e2c5a6.zip | |
[lldb] Fix crash in AccessDeclContextSanity when copying FunctionTemplateDecl inside a record.
Summary:
We currently don't set access specifiers for function template declarations. This seems to be fine
as long as the function template is not declared inside any record in which case Clang asserts
with the following once we try to query it's access:
```
Assertion failed: (Access != AS_none && "Access specifier is AS_none inside a record decl"), function AccessDeclContextSanity,
```
This patch just marks these function template declarations as public to make Clang happy.
Reviewers: shafik, teemperor
Reviewed By: teemperor
Subscribers: JDevlieghere, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D71909
Diffstat (limited to 'lldb/packages/Python')
| -rw-r--r-- | lldb/packages/Python/lldbsuite/test/commands/expression/completion-crash2/TestCompletionCrash2.py | 4 | ||||
| -rw-r--r-- | lldb/packages/Python/lldbsuite/test/commands/expression/regression-access-function-template-in-record/TestRegressionAccessFunctionTemplateInRecord.py | 4 | ||||
| -rw-r--r-- | lldb/packages/Python/lldbsuite/test/commands/expression/regression-access-function-template-in-record/main.cpp (renamed from lldb/packages/Python/lldbsuite/test/commands/expression/completion-crash2/main.cpp) | 0 |
3 files changed, 4 insertions, 4 deletions
diff --git a/lldb/packages/Python/lldbsuite/test/commands/expression/completion-crash2/TestCompletionCrash2.py b/lldb/packages/Python/lldbsuite/test/commands/expression/completion-crash2/TestCompletionCrash2.py deleted file mode 100644 index 922347aa781..00000000000 --- a/lldb/packages/Python/lldbsuite/test/commands/expression/completion-crash2/TestCompletionCrash2.py +++ /dev/null @@ -1,4 +0,0 @@ -from lldbsuite.test import lldbinline -from lldbsuite.test import decorators - -lldbinline.MakeInlineTest(__file__, globals(), [decorators.skipIf(bugnumber="rdar://53754063")]) diff --git a/lldb/packages/Python/lldbsuite/test/commands/expression/regression-access-function-template-in-record/TestRegressionAccessFunctionTemplateInRecord.py b/lldb/packages/Python/lldbsuite/test/commands/expression/regression-access-function-template-in-record/TestRegressionAccessFunctionTemplateInRecord.py new file mode 100644 index 00000000000..f08c0dcbda9 --- /dev/null +++ b/lldb/packages/Python/lldbsuite/test/commands/expression/regression-access-function-template-in-record/TestRegressionAccessFunctionTemplateInRecord.py @@ -0,0 +1,4 @@ +from lldbsuite.test import lldbinline +from lldbsuite.test import decorators + +lldbinline.MakeInlineTest(__file__, globals(), []) diff --git a/lldb/packages/Python/lldbsuite/test/commands/expression/completion-crash2/main.cpp b/lldb/packages/Python/lldbsuite/test/commands/expression/regression-access-function-template-in-record/main.cpp index 02f15c295c2..02f15c295c2 100644 --- a/lldb/packages/Python/lldbsuite/test/commands/expression/completion-crash2/main.cpp +++ b/lldb/packages/Python/lldbsuite/test/commands/expression/regression-access-function-template-in-record/main.cpp |
