diff options
| author | Pavel Labath <labath@google.com> | 2016-10-26 11:13:56 +0000 |
|---|---|---|
| committer | Pavel Labath <labath@google.com> | 2016-10-26 11:13:56 +0000 |
| commit | 42eb6908e035c0b8160591c680007936ec306400 (patch) | |
| tree | 19bdf1269aa7e2be921d278b94fe6800e534c906 /lldb/packages/Python | |
| parent | b380b24e6edc83030ea6bcc815763b77cbbf9a75 (diff) | |
| download | bcm5719-llvm-42eb6908e035c0b8160591c680007936ec306400.tar.gz bcm5719-llvm-42eb6908e035c0b8160591c680007936ec306400.zip | |
Don't set a software stepping breakpoint at 0 on arm or mips.
Summary:
Check whether the setting the breakpoint failed during instruction emulation. If
it did, the next pc is likely in unmapped memory, and the inferior will crash
anyway after the next instruction. Do not return an error in this case, but just
continue stepping.
Reenabled the crash during step test for android/linux.
Reviewers: labath
Subscribers: aemerson, rengolin, tberghammer, danalbert, srhines, lldb-commits
Differential Revision: https://reviews.llvm.org/D25926
Author: Jason Majors <jmajors@google.com>
llvm-svn: 285187
Diffstat (limited to 'lldb/packages/Python')
| -rw-r--r-- | lldb/packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py b/lldb/packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py index a9a8aa31e37..5343e19ee20 100644 --- a/lldb/packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py +++ b/lldb/packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py @@ -21,11 +21,6 @@ class CreateDuringStepTestCase(TestBase): self.breakpoint = line_number('main.cpp', '// Set breakpoint here') @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778") - @expectedFailureAndroid("llvm.org/pr24497", archs=['arm', 'aarch64']) - @expectedFailureAll( - oslist=["linux"], - archs=["arm"], - bugnumber="llvm.org/pr24497") # IO error due to breakpoint at invalid address @expectedFailureAll(triple=re.compile('^mips')) def test_step_inst_with(self): |
