summaryrefslogtreecommitdiffstats
path: root/lldb/packages/Python/lldbsuite
diff options
context:
space:
mode:
authorVedant Kumar <vsk@apple.com>2016-02-08 19:25:45 +0000
committerVedant Kumar <vsk@apple.com>2016-02-08 19:25:45 +0000
commit39f01975ef346beea052004e233471b900929b85 (patch)
treeed6665dfa13ff6c47601305c2a367495dca89dcd /lldb/packages/Python/lldbsuite
parente4ddfd14f162562749cb219e909dd0c2fe844d30 (diff)
downloadbcm5719-llvm-39f01975ef346beea052004e233471b900929b85.tar.gz
bcm5719-llvm-39f01975ef346beea052004e233471b900929b85.zip
[Coverage] Fix crash when handling certain macro expansions
When handling 'if' statements, we crash if the condition and the consequent branch are spanned by a single macro expansion. The crash occurs because of a sanity 'reset' in popRegions(): if an expansion exactly spans an entire region, we set MostRecentLocation to the start of the expansion (its 'include location'). This ensures we don't handleFileExit() ourselves out of the expansion before we're done processing all of the regions within it. This is tested in test/CoverageMapping/macro-expressions.c. This causes a problem when an expansion spans both the condition and the consequent branch of an 'if' statement. MostRecentLocation is updated to the start of the 'if' statement in popRegions(), so the file for the expansion isn't exited by the time we're done handling the statement. We then crash with 'fatal: File exit not handled before popRegions'. The fix for this is to detect these kinds of expansions, and conservatively update MostRecentLocation to the end of expansion region containing the conditional. I've added tests to make sure we don't have the same problem with other kinds of statements. rdar://problem/23630316 Differential Revision: http://reviews.llvm.org/D16934 llvm-svn: 260129
Diffstat (limited to 'lldb/packages/Python/lldbsuite')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud