summaryrefslogtreecommitdiffstats
path: root/lldb/packages/Python/lldbsuite
diff options
context:
space:
mode:
authorAlexander Kornienko <alexfh@google.com>2016-04-04 14:31:36 +0000
committerAlexander Kornienko <alexfh@google.com>2016-04-04 14:31:36 +0000
commit09464e63d842e1e0e6be300b6bb59bc9c1e7ecdf (patch)
tree0e3a899d441530e52facc1841ca4986dd53c504d /lldb/packages/Python/lldbsuite
parent193b99c53c9d6a3fb221cf2dcebc5fb7b76d0fd3 (diff)
downloadbcm5719-llvm-09464e63d842e1e0e6be300b6bb59bc9c1e7ecdf.tar.gz
bcm5719-llvm-09464e63d842e1e0e6be300b6bb59bc9c1e7ecdf.zip
[clang-tidy] fix a couple of modernize-use-override bugs
Fix for __declspec attributes and const=0 without space This patch is to address 2 problems I found with Clang-tidy:modernize-use-override. 1: missing spaces on pure function decls. Orig: void pure() const=0 Problem: void pure() constoverride =0 Fixed: void pure() const override =0 2: This is ms-extension specific, but possibly applies to other attribute types. The override is placed before the attribute which doesn’t work well with declspec as this attribute can be inherited or placed before the method identifier. Orig: class __declspec(dllexport) X : public Y { void p(); }; Problem: class override __declspec(dllexport) class X : public Y { void p(); }; Fixed: class __declspec(dllexport) class X : public Y { void p() override; }; Patch by Robert Bolter! Differential Revision: http://reviews.llvm.org/D18396 llvm-svn: 265298
Diffstat (limited to 'lldb/packages/Python/lldbsuite')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud