summaryrefslogtreecommitdiffstats
path: root/lldb/packages/Python/lldbsuite/test
diff options
context:
space:
mode:
authorAlex Langford <apl@fb.com>2019-03-07 22:37:23 +0000
committerAlex Langford <apl@fb.com>2019-03-07 22:37:23 +0000
commitd672e533d5cbd37c7a5f623565ece47167dec411 (patch)
treeb6fdf8f3b89e90d3076e7b2463f94fd8b43706a6 /lldb/packages/Python/lldbsuite/test
parent46fac9c4f270eac7072f88477385e973983b88f5 (diff)
downloadbcm5719-llvm-d672e533d5cbd37c7a5f623565ece47167dec411.tar.gz
bcm5719-llvm-d672e533d5cbd37c7a5f623565ece47167dec411.zip
Fix TestPaths.py on windows
I committed an implementation of GetClangResourceDir on windows but forgot to update this test. I merged the tests like I intended to, but I realized that the test was actually failing. After looking into it, it appears that FileSystem::Resolve was taking the path and setting the FileSpec's Directory to "/path/to/lldb/lib/clang/" and the File to "9.0.0" which isn't what we want. So I removed the resolve line from DefaultComputeClangResourceDir. llvm-svn: 355648
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test')
-rw-r--r--lldb/packages/Python/lldbsuite/test/functionalities/paths/TestPaths.py12
1 files changed, 2 insertions, 10 deletions
diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/paths/TestPaths.py b/lldb/packages/Python/lldbsuite/test/functionalities/paths/TestPaths.py
index 96e1446c278..816751cd879 100644
--- a/lldb/packages/Python/lldbsuite/test/functionalities/paths/TestPaths.py
+++ b/lldb/packages/Python/lldbsuite/test/functionalities/paths/TestPaths.py
@@ -25,22 +25,14 @@ class TestPaths(TestBase):
lldb.ePathTypePythonDir,
lldb.ePathTypeLLDBSystemPlugins,
lldb.ePathTypeLLDBUserPlugins,
- lldb.ePathTypeLLDBTempSystemDir]
+ lldb.ePathTypeLLDBTempSystemDir,
+ lldb.ePathTypeClangDir]
for path_type in dir_path_types:
f = lldb.SBHostOS.GetLLDBPath(path_type)
# No directory path types should have the filename set
self.assertTrue(f.GetFilename() is None)
- # TODO: Merge into test_path when GetClangResourceDir is implemented on
- # windows
- @expectedFailureAll(oslist=["windows"])
- @no_debug_info_test
- def test_clang_dir_path(self):
- '''Test to make sure clang dir is set correctly'''
- clang_dir = lldb.SBHostOS.GetLLDBPath(lldb.ePathTypeClangDir)
- self.assertFalse(clang_dir.GetDirectory() is None)
-
@no_debug_info_test
def test_directory_doesnt_end_with_slash(self):
current_directory_spec = lldb.SBFileSpec(os.path.curdir)
OpenPOWER on IntegriCloud