summaryrefslogtreecommitdiffstats
path: root/lldb/packages/Python/lldbsuite/test
diff options
context:
space:
mode:
authorAlex Langford <apl@fb.com>2019-07-23 00:41:00 +0000
committerAlex Langford <apl@fb.com>2019-07-23 00:41:00 +0000
commitc7f9bfb0e4babf6e588bb0988e3e335a6e9f56ff (patch)
treeb36da04f2769702bd8f7c91311bf44112c06261b /lldb/packages/Python/lldbsuite/test
parente5001fe5c1ac00ced55168758ddccaa434175037 (diff)
downloadbcm5719-llvm-c7f9bfb0e4babf6e588bb0988e3e335a6e9f56ff.tar.gz
bcm5719-llvm-c7f9bfb0e4babf6e588bb0988e3e335a6e9f56ff.zip
[lldb][test_suite] Fix skipIfTargetAndroid decorator
Summary: Delete the duplicate func `skipIfTargetAndroid` Fix the old one. It didn't work for missing an argument `bugnumber`, this somehow made the decorator failed Differential Revision: https://reviews.llvm.org/D64583 Patch by Wanyi Ye <kusmour@gmail.com> llvm-svn: 366771
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test')
-rw-r--r--lldb/packages/Python/lldbsuite/test/decorators.py10
1 files changed, 3 insertions, 7 deletions
diff --git a/lldb/packages/Python/lldbsuite/test/decorators.py b/lldb/packages/Python/lldbsuite/test/decorators.py
index 0493a4316ed..c4343b3ffbc 100644
--- a/lldb/packages/Python/lldbsuite/test/decorators.py
+++ b/lldb/packages/Python/lldbsuite/test/decorators.py
@@ -596,11 +596,6 @@ def skipIfWindows(func):
"""Decorate the item to skip tests that should be skipped on Windows."""
return skipIfPlatform(["windows"])(func)
-def skipIfTargetAndroid(func):
- return unittest2.skipIf(lldbplatformutil.target_is_android(),
- "skip on target Android")(func)
-
-
def skipUnlessWindows(func):
"""Decorate the item to skip tests that should be skipped on any non-Windows platform."""
return skipUnlessPlatform(["windows"])(func)
@@ -652,7 +647,7 @@ def skipUnlessPlatform(oslist):
"requires one of %s" % (", ".join(oslist)))
-def skipIfTargetAndroid(api_levels=None, archs=None):
+def skipIfTargetAndroid(bugnumber=None, api_levels=None, archs=None):
"""Decorator to skip tests when the target is Android.
Arguments:
@@ -665,7 +660,8 @@ def skipIfTargetAndroid(api_levels=None, archs=None):
_skip_for_android(
"skipping for android",
api_levels,
- archs))
+ archs),
+ bugnumber)
def skipUnlessSupportedTypeAttribute(attr):
"""Decorate the item to skip test unless Clang supports type __attribute__(attr)."""
OpenPOWER on IntegriCloud