summaryrefslogtreecommitdiffstats
path: root/lldb/packages/Python/lldbsuite/test
diff options
context:
space:
mode:
authorPavel Labath <labath@google.com>2017-07-07 11:02:19 +0000
committerPavel Labath <labath@google.com>2017-07-07 11:02:19 +0000
commit96e600fcf55128b4f283cc70be64d2e3eb694a1a (patch)
treefdebaf75d54cc1cf309da0c475a9cda730918aec /lldb/packages/Python/lldbsuite/test
parentd4550baf3b6dceceaa13e91563b053538e3697bb (diff)
downloadbcm5719-llvm-96e600fcf55128b4f283cc70be64d2e3eb694a1a.tar.gz
bcm5719-llvm-96e600fcf55128b4f283cc70be64d2e3eb694a1a.zip
Add a NativeProcessProtocol Factory class
Summary: This replaces the static functions used for creating NativeProcessProtocol instances with a factory pattern, and modernizes the interface of the new class in the process -- I use llvm::Expected instead of the Status+value combo. I also move some of the common code (like the Delegate registration into the base class). The new arrangement has multiple benefits: - it removes the NativeProcess*** dependency from Process/gdb-remote (which for example means that liblldb no longer pulls in this code). - it enables unit testing of the GDBRemoteCommunicationServerLLGS class (by providing a mock Native Process). - serves as another example on how to use the llvm::Expected class (I couldn't get rid of the Initialize-type functions completely here because of the use of shared_from_this, but that's the next thing on my list here) Tests still pass on Linux and I've made sure NetBSD compiles after this. Reviewers: zturner, eugene, krytarowski Subscribers: srhines, lldb-commits, mgorny Differential Revision: https://reviews.llvm.org/D33778 llvm-svn: 307390
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud