diff options
author | Zachary Turner <zturner@google.com> | 2016-03-18 23:47:48 +0000 |
---|---|---|
committer | Zachary Turner <zturner@google.com> | 2016-03-18 23:47:48 +0000 |
commit | 29365da0e8ac0dd64c90d427ddc349c392fa8c62 (patch) | |
tree | d6e7ef9aeede39b0abce256489c4120264f16993 /lldb/packages/Python/lldbsuite/test | |
parent | a3a019cf90d55ad46c04c0f9ffa9c7fc2c19f36d (diff) | |
download | bcm5719-llvm-29365da0e8ac0dd64c90d427ddc349c392fa8c62.tar.gz bcm5719-llvm-29365da0e8ac0dd64c90d427ddc349c392fa8c62.zip |
Delete the custom implementation of signal() on Windows.
The Windows SDK provides a version of signal() that is much more
limited compared to other platforms. It only supports about 5-6
signal values. LLDB uses signals for a number of things, most
notably to handle Ctrl+C so we can gracefully shut down. The
portability solution to this on Windows has been to provide a
hand-rolled implementation of `signal` using the name `signal`
so that you could write code that simply calls signal directly
and it would work.
But this introduces a multiply defined symbol with the builtin
version and depending on how you included header files, you could
get yourself into a situation where you had linker errors. To
make matters worse, it led to a ton of compiler warnings. Worst
of all though is that this custom implementation of signal was,
in fact, identical for the purposes of handling Ctrl+C as the
builtin implementation of signal. So it seems to have literally
not been serving any useful purpose.
This patch deletes all the custom signal() functions for Windows,
and includes the signal.h system header, so that any calls to
signal now go to the actual version provided by the Windows SDK.
Differential Revision: http://reviews.llvm.org/D18287
llvm-svn: 263858
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test')
0 files changed, 0 insertions, 0 deletions