Enable test log collection from remote debug servers (take 2)

Summary:
This is a slightly reworked version of D16322, which I had reverted because it did not do what it
advertised. Differences from the previous version are:
- moved the code for cleaning up the remote working dir to a later point as it was removing the
  log file before we could get to it.
- specialised log downloading code for gdb-remote tests is not needed, as this will cover that
  use case as well.

Reviewers: tfiala

Subscribers: lldb-commits

Differential Revision: http://reviews.llvm.org/D21898

llvm-svn: 274491

1 files changed, 0 insertions, 8 deletions

diff --git a/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py b/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
index 61146eb0fa4..d63ddbe3999 100644
--- a/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
+++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
@@ -78,7 +78,6 @@ class GdbRemoteTestCaseBase(TestBase):
         TestBase.setUp(self)
 
         self.setUpBaseLogging()
-        self._remote_server_log_file = None
         self.debug_monitor_extra_args = []
         self._pump_queues = socket_packet_pump.PumpQueues()
 
@@ -114,12 +113,6 @@ class GdbRemoteTestCaseBase(TestBase):
     def tearDown(self):
         self._pump_queues.verify_queues_empty()
 
-        if self._remote_server_log_file is not None:
-            lldb.remote_platform.Get(lldb.SBFileSpec(self._remote_server_log_file),
-                    lldb.SBFileSpec(self.getLocalServerLogFile()))
-            lldb.remote_platform.Run(lldb.SBPlatformShellCommand("rm " + self._remote_server_log_file))
-            self._remote_server_log_file = None
-
         self.logger.removeHandler(self._verbose_log_handler)
         self._verbose_log_handler = None
         TestBase.tearDown(self)
@@ -133,7 +126,6 @@ class GdbRemoteTestCaseBase(TestBase):
 
         if lldb.remote_platform:
             log_file = lldbutil.join_remote_paths(lldb.remote_platform.GetWorkingDirectory(), "server.log")
-            self._remote_server_log_file = log_file
         else:
             log_file = self.getLocalServerLogFile()