summaryrefslogtreecommitdiffstats
path: root/lldb/packages/Python/lldbsuite/test/python_api
diff options
context:
space:
mode:
authorFrederic Riss <friss@apple.com>2019-09-04 16:13:12 +0000
committerFrederic Riss <friss@apple.com>2019-09-04 16:13:12 +0000
commitcc5b509b9edacf7fa9af455b69af1f4357a668db (patch)
treea7754bc6f142973ccbfe631c4d1d6b53830ce3ee /lldb/packages/Python/lldbsuite/test/python_api
parent5465875e9361b58a357c118884ca09340236a664 (diff)
downloadbcm5719-llvm-cc5b509b9edacf7fa9af455b69af1f4357a668db.tar.gz
bcm5719-llvm-cc5b509b9edacf7fa9af455b69af1f4357a668db.zip
Workaround TestConcurrentMany* flakiness in a more pricipled way
The flakiness on our local machines seems to come for a race in the kernel between task_suspend and the creation of the Mach exceptions for the threads that hit breakpoints. The debugserver code is written with the assumption that the kernel will be able to provide us with all the exceptions for a given task once task_suspend returns. On machines with higher core counts, this seems not to be the case. The first batch of exceptions we get after task_suspend does not contain exceptions for all the threads that have hit a breakpoint, thus they get misreprorted in the first stop packet. Adding a 1ms timeout to the call that retrieves the batch of exceptions seems to workaround the issue reliably on our machines, and it shoulnd't impact standard debugging scenarios too much (a stop will incur an additional 1ms delay). We'll be talking to the kernel team to figure out the right contract for those APIs. This patch also reverts part of Jonas' previous workaround for the issue (r370785). llvm-svn: 370916
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/python_api')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud