diff options
author | Alex Richardson <Alexander.Richardson@cl.cam.ac.uk> | 2019-12-13 11:28:20 +0000 |
---|---|---|
committer | Alex Richardson <Alexander.Richardson@cl.cam.ac.uk> | 2019-12-13 12:22:03 +0000 |
commit | be15dfa88fb1ed94d12f374797f98ede6808f809 (patch) | |
tree | 46d331f25e9e482fa8d4d422edd8916346e983b9 /lldb/packages/Python/lldbsuite/test/python_api | |
parent | 2bbd32f5e8f0f62d895966e2623d9bdb9778b50b (diff) | |
download | bcm5719-llvm-be15dfa88fb1ed94d12f374797f98ede6808f809.tar.gz bcm5719-llvm-be15dfa88fb1ed94d12f374797f98ede6808f809.zip |
[NFC] Use EVT instead of bool for getSetCCInverse()
Summary:
The use of a boolean isInteger flag (generally initialized using
VT.isInteger()) caused errors in our out-of-tree CHERI backend
(https://github.com/CTSRD-CHERI/llvm-project).
In our backend, pointers use a separate ValueType (iFATPTR) and therefore
.isInteger() returns false. This meant that getSetCCInverse() was using the
floating-point variant and generated incorrect code for us:
`(void *)0x12033091e < (void *)0xffffffffffffffff` would return false.
Committing this change will significantly reduce our merge conflicts
for each upstream merge.
Reviewers: spatel, bogner
Reviewed By: bogner
Subscribers: wuzish, arsenm, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70917
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/python_api')
0 files changed, 0 insertions, 0 deletions