diff options
author | Jorge Gorbe Moya <jgorbe@google.com> | 2019-04-01 20:37:22 +0000 |
---|---|---|
committer | Jorge Gorbe Moya <jgorbe@google.com> | 2019-04-01 20:37:22 +0000 |
commit | 4665aca8ca769f1389d83f59e8774c749b2f9d88 (patch) | |
tree | 97f31e3387e0a794b47b8bd5d2996beccd51a4dc /lldb/packages/Python/lldbsuite/test/python_api | |
parent | 66d7eb97045e0fda283ff336297e1a46869152f6 (diff) | |
download | bcm5719-llvm-4665aca8ca769f1389d83f59e8774c749b2f9d88.tar.gz bcm5719-llvm-4665aca8ca769f1389d83f59e8774c749b2f9d88.zip |
[lldb-vscode] Add logic to handle EOF when reading from lldb-vscode stdout.
Summary:
This change prevents the lldb-vscode test harness from hanging up waiting for
new messages when the lldb-vscode subprocess crashes.
Now, when an EOF from the subprocess pipe is detected we enqueue a `None` packet
in the received packets list. Then, during the message processing loop, we can
use this `None` packet to tell apart the case where lldb-vscode has terminated
unexpectedly from the normal situation where no pending messages means blocking
and waiting for more data.
I believe this should be enough to fix the issues with these tests hanging on
multiple platforms. Once this lands, I'll prepare and test a separate change
removing the @skipIfLinux annotations.
Reviewers: clayborg, zturner
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D59849
llvm-svn: 357426
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/python_api')
0 files changed, 0 insertions, 0 deletions