diff options
| author | Jonas Devlieghere <jonas@devlieghere.com> | 2019-09-23 20:36:46 +0000 |
|---|---|---|
| committer | Jonas Devlieghere <jonas@devlieghere.com> | 2019-09-23 20:36:46 +0000 |
| commit | 948786c9295de3ec8536d8ec6ec7dd45b3f66184 (patch) | |
| tree | 6a21cfc885ff8e3ff64505912ba50d5591fad516 /lldb/packages/Python/lldbsuite/test/python_api/value/TestValueAPI.py | |
| parent | 4750d79ac686861c9d51996611dd8413178396c4 (diff) | |
| download | bcm5719-llvm-948786c9295de3ec8536d8ec6ec7dd45b3f66184.tar.gz bcm5719-llvm-948786c9295de3ec8536d8ec6ec7dd45b3f66184.zip | |
File::SetDescriptor() should require options
lvm_private::File::GetStream() can fail if m_options == 0
It's not clear from the header a File created with a descriptor will be
not be usable by many parts of LLDB unless SetOptions is also called,
but it is.
This is because those parts of LLDB rely on GetStream() to use the
file, and that in turn relies on calling fdopen on the descriptor. When
calling fdopen, GetStream relies on m_options to determine the access
mode. If m_options has never been set, GetStream() will fail.
This patch adds options as a required argument to File::SetDescriptor
and the corresponding constructor.
Patch by: Lawrence D'Anna
Differential revision: https://reviews.llvm.org/D67792
llvm-svn: 372652
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/python_api/value/TestValueAPI.py')
0 files changed, 0 insertions, 0 deletions
