diff options
| author | Reid Kleckner <rnk@google.com> | 2018-11-13 23:44:39 +0000 |
|---|---|---|
| committer | Reid Kleckner <rnk@google.com> | 2018-11-13 23:44:39 +0000 |
| commit | 944843c8802da1a7c07094b7e5af3416f0bba964 (patch) | |
| tree | 6ad6205da9133d9e61c2dae6e94d6ede571f4ec9 /lldb/packages/Python/lldbsuite/test/python_api/value/TestValueAPI.py | |
| parent | 4e97ec94d9c13b14e76d3377b27c798436326737 (diff) | |
| download | bcm5719-llvm-944843c8802da1a7c07094b7e5af3416f0bba964.tar.gz bcm5719-llvm-944843c8802da1a7c07094b7e5af3416f0bba964.zip | |
[PDB] Simplify symbol handling code, NFC
- Make mergeSymbolRecords a method of PDBLinker to reduce the number of
parameters it needs.
- Remove a stale FIXME comment about error handling. We already drop
unknown symbol records, log them, and continue.
- Update a comment about why we're copying the symbol record. We do it
to realign the record. We can already mutate the symbol record memory,
it's memory allocated by relocateDebugChunk.
- Avoid the extra `CVSymbol NewSym` variable. We can mutate Sym in
place, which is best, since we're mutating the underlying record anyway.
llvm-svn: 346817
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/python_api/value/TestValueAPI.py')
0 files changed, 0 insertions, 0 deletions
