summaryrefslogtreecommitdiffstats
path: root/lldb/packages/Python/lldbsuite/test/python_api/thread/TestThreadAPI.py
diff options
context:
space:
mode:
authorSimon Tatham <simon.tatham@arm.com>2020-01-06 16:33:14 +0000
committerSimon Tatham <simon.tatham@arm.com>2020-01-06 16:33:16 +0000
commit34817e04feeb00dcd0515e5810218587438bd5a8 (patch)
treef5cce40581b160dc89a74f89d3325d3256939f5f /lldb/packages/Python/lldbsuite/test/python_api/thread/TestThreadAPI.py
parent4978296cd8e4d10724cfa41f0308d256c0fd490c (diff)
downloadbcm5719-llvm-34817e04feeb00dcd0515e5810218587438bd5a8.tar.gz
bcm5719-llvm-34817e04feeb00dcd0515e5810218587438bd5a8.zip
[ARM,MVE] Fix many signedness errors in MVE intrinsics.
Summary: Running an end-to-end test last week I noticed that a lot of the ACLE intrinsics that operate differently on vectors of signed and unsigned integers were ending up generating the signed version of the instruction unconditionally. This is because the IR intrinsics had no way to distinguish signed from unsigned: the LLVM type system just calls them both `v8i16` (or whatever), so you need either separate intrinsics for signed and unsigned, or a flag parameter that tells ISel which one to choose. This patch fixes all the problems of that kind that I've noticed, by adding an i32 flag parameter to many of the IR intrinsics which is set to 1 for unsigned (matching the existing practice in cases where we got it right), and conditioning all the isel patterns on that flag. So the fundamental change is in `IntrinsicsARM.td`, changing the low-level IR intrinsics API; there are knock-on changes in `arm_mve.td` (adjusting code gen for the ACLE intrinsics to use the modified API) and in `ARMInstrMVE.td` (adjusting isel to expect the new unsigned flags). The rest of this patch is boringly updating tests. Reviewers: dmgreen, miyuki, MarkMurrayARM Reviewed By: dmgreen Subscribers: kristof.beyls, hiraditya, cfe-commits, llvm-commits Tags: #clang, #llvm Differential Revision: https://reviews.llvm.org/D72270
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/python_api/thread/TestThreadAPI.py')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud