diff options
| author | Eric Fiselier <eric@efcs.ca> | 2016-09-14 23:52:01 +0000 |
|---|---|---|
| committer | Eric Fiselier <eric@efcs.ca> | 2016-09-14 23:52:01 +0000 |
| commit | a75c1bf9f620dd99bb6763a941453209ec329fb5 (patch) | |
| tree | 9400b142d78558a985dcff21f02d7522ef746896 /lldb/packages/Python/lldbsuite/test/python_api/target | |
| parent | 9efb1bdcc4be9613188e7a62e9c5bbd80b3f4895 (diff) | |
| download | bcm5719-llvm-a75c1bf9f620dd99bb6763a941453209ec329fb5.tar.gz bcm5719-llvm-a75c1bf9f620dd99bb6763a941453209ec329fb5.zip | |
Revert r280944 - Added 'inline' attribute to basic_string's destructor
This patch causes a couple of issues:
1) It triggers http://llvm.org/PR30341. Although the bug is not truly a libc++
bug it breaks the LLVM build using libc++. Reverting this patch is only
a temporary workaround until Clang is fixed.
2) It adds yet another ABI incompatibility when libc++.so is compiled with GCC.
Specifically GCC doesn't ignore the _LIBCPP_INLINE_VISIBILITY on the out-of-line
definition when compiling the dylib. This causes the externally instantiated
~basic_string symbol to have hidden visibility.
This patch should be recommitted after addressing (1) and (2). (2) can be fixed
by adding _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY which is defined as
__attribute__((visibility("default"), always_inline)) as opposed to
_LIBCPP_INLINE_VISIBILITY which makes the symbol hidden.
llvm-svn: 281562
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/python_api/target')
0 files changed, 0 insertions, 0 deletions
