diff options
| author | Calixte Denizet <calixte.denizet@gmail.com> | 2019-12-10 13:22:33 +0100 |
|---|---|---|
| committer | Calixte Denizet <calixte.denizet@gmail.com> | 2019-12-12 09:23:32 +0100 |
| commit | 02ce9d8ef5a84bc884de4105eae5f8736ef67634 (patch) | |
| tree | dd1e16637f564cacffaf849e5a015b2e3205762b /lldb/packages/Python/lldbsuite/test/python_api/signals | |
| parent | fa0fc04a4f950461e3f5675487b477c94e456842 (diff) | |
| download | bcm5719-llvm-02ce9d8ef5a84bc884de4105eae5f8736ef67634.tar.gz bcm5719-llvm-02ce9d8ef5a84bc884de4105eae5f8736ef67634.zip | |
[compiler-rt] Add a critical section when flushing gcov counters
Summary:
Counters can be flushed in a multi-threaded context for example when the process is forked in different threads (https://github.com/llvm/llvm-project/blob/master/llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp#L632-L663).
In order to avoid pretty bad things, a critical section is needed around the flush.
We had a lot of crashes in this code in Firefox CI when we switched to clang for linux ccov builds and those crashes disappeared with this patch.
Reviewers: marco-c, froydnj, dmajor, davidxl, vsk
Reviewed By: marco-c, dmajor
Subscribers: ahatanak, froydnj, dmajor, dberris, jfb, #sanitizers, llvm-commits, sylvestre.ledru
Tags: #sanitizers, #llvm
Differential Revision: https://reviews.llvm.org/D70910
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/python_api/signals')
0 files changed, 0 insertions, 0 deletions
