diff options
| author | Mitchell Balan <mitchell@stellarscience.com> | 2019-11-19 07:46:48 -0500 |
|---|---|---|
| committer | Mitchell Balan <mitchell@stellarscience.com> | 2019-11-19 07:52:32 -0500 |
| commit | df11117086fe8effdc5abe6a9955f659876dc64f (patch) | |
| tree | b9429782d17ca2bd507ad585cb516d4534f22a3e /lldb/packages/Python/lldbsuite/test/python_api/signals/main.cpp | |
| parent | 1315f4e009b097d7d1a2a5cf116c1ad55ed5c190 (diff) | |
| download | bcm5719-llvm-df11117086fe8effdc5abe6a9955f659876dc64f.tar.gz bcm5719-llvm-df11117086fe8effdc5abe6a9955f659876dc64f.zip | |
[clang-tidy] modernize-use-override new option AllowOverrideAndFinal
Summary:
In addition to adding `override` wherever possible, clang-tidy's `modernize-use-override` nicely removes `virtual` when `override` or `final` is specified, and further removes override when final is specified. While this is great default behavior, when code needs to be compiled with gcc at high warning levels that include `gcc -Wsuggest-override` or `gcc -Werror=suggest-override`, clang-tidy's removal of the redundant `override` keyword causes gcc to emit a warning or error. This discrepancy / conflict has been noted by others including a comment on Stack Overflow and by Mozilla's Firefox developers.
This patch adds an AllowOverrideAndFinal option defaulting to 0 - thus preserving current behavior - that when enabled allows both `override` and `final` to co-exist, while still fixing all other issues.
The patch includes a test file verifying all combinations of virtual/override/final, and mentions the new option in the release notes.
Reviewers: alexfh, djasper, JonasToth
Patch by: poelmanc
Subscribers: JonasToth, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70165
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/python_api/signals/main.cpp')
0 files changed, 0 insertions, 0 deletions
