summaryrefslogtreecommitdiffstats
path: root/lldb/packages/Python/lldbsuite/test/python_api/signals/main.cpp
diff options
context:
space:
mode:
authorJoel E. Denny <jdenny.ornl@gmail.com>2019-10-17 14:02:42 +0000
committerJoel E. Denny <dennyje@ornl.gov>2019-10-29 15:13:52 -0400
commitb163806cdc317ee160a2ce694958c088a949fa7d (patch)
tree12022f7999d0698318fd87bd22c1f278bc12170a /lldb/packages/Python/lldbsuite/test/python_api/signals/main.cpp
parent772533d9214b6e23762847fc7080a4201396fb10 (diff)
downloadbcm5719-llvm-b163806cdc317ee160a2ce694958c088a949fa7d.tar.gz
bcm5719-llvm-b163806cdc317ee160a2ce694958c088a949fa7d.zip
[lit] Make internal diff work in pipelines
When using lit's internal shell, RUN lines like the following accidentally execute an external `diff` instead of lit's internal `diff`: ``` # RUN: program | diff file - # RUN: not diff file1 file2 | FileCheck %s ``` Such cases exist now, in `clang/test/Analysis` for example. We are preparing patches to ensure lit's internal `diff` is called in such cases, which will then fail because lit's internal `diff` cannot currently be used in pipelines and doesn't recognize `-` as a command-line option. To enable pipelines, this patch moves lit's `diff` implementation into an out-of-process script, similar to lit's `cat` implementation. A follow-up patch will implement `-` to mean stdin. Also, when lit's `diff` prints differences to stdout in Windows, this patch ensures it always terminate lines with `\n` not `\r\n`. That way, strict FileCheck directives checking the `diff` output succeed in both Linux and Windows. This wasn't an issue when `diff` was internal to lit because `diff` didn't then write to the true stdout, which is where the `\n` -> `\r\n` conversion happened in Python. Reviewed By: probinson, stella.stamenova Differential Revision: https://reviews.llvm.org/D66574
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/python_api/signals/main.cpp')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud