diff options
| author | Nicolai Haehnle <nhaehnle@gmail.com> | 2015-12-17 16:46:42 +0000 |
|---|---|---|
| committer | Nicolai Haehnle <nhaehnle@gmail.com> | 2015-12-17 16:46:42 +0000 |
| commit | 87323da6eb2e49d8b34d8e2697fcee3799d42679 (patch) | |
| tree | 17d63011a330e2f7046058be13b1e558773c9cbc /lldb/packages/Python/lldbsuite/test/python_api/module_section | |
| parent | 33a0eb740e59d5498c835fd8d41f78ef7359e4a8 (diff) | |
| download | bcm5719-llvm-87323da6eb2e49d8b34d8e2697fcee3799d42679.tar.gz bcm5719-llvm-87323da6eb2e49d8b34d8e2697fcee3799d42679.zip | |
AMDGPU: Fix off-by-one in SIRegisterInfo::eliminateFrameIndex
Summary:
The method insertNOPs expected the number of wait states to be passed as
parameter, while eliminateFrameIndex passed the immediate argument for the
S_NOP, leading to an off-by-one error. Rename the method to make the
meaning of its parameter clearer. The number of 4 / 5 wait states (which
is what the method has always _tried_ to do according to the comment) is
correct according to the hardware docs.
I stumbled upon this while trying to track down the cause of
https://bugs.freedesktop.org/show_bug.cgi?id=93264. While clearly needed,
this patch unfortunately does not fix that bug...
Reviewers: arsenm, tstellarAMD
Subscribers: arsenm, llvm-commits
Differential Revision: http://reviews.llvm.org/D15542
llvm-svn: 255906
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/python_api/module_section')
0 files changed, 0 insertions, 0 deletions
