diff options
| author | Lawrence D'Anna <lawrence_danna@apple.com> | 2019-10-30 09:45:13 -0700 |
|---|---|---|
| committer | Lawrence D'Anna <lawrence_danna@apple.com> | 2019-10-30 09:46:51 -0700 |
| commit | 3071ebf7b38341e89be04aa64c257c4643e0648c (patch) | |
| tree | dd8c3ba1dd23d951146cce6085e576635f8c0cb8 /lldb/packages/Python/lldbsuite/test/python_api/file_handle | |
| parent | fbe7f5e9729ac24374182fca92242f88baa08f90 (diff) | |
| download | bcm5719-llvm-3071ebf7b38341e89be04aa64c257c4643e0648c.tar.gz bcm5719-llvm-3071ebf7b38341e89be04aa64c257c4643e0648c.zip | |
[LLDB][PythonFile] fix dangerous borrow semantics on python2
Summary:
It is inherently unsafe to allow a python program to manipulate borrowed
memory from a python object's destructor. It would be nice to
flush a borrowed file when python is finished with it, but it's not safe
to do on python 2.
Python 3 does not suffer from this issue.
Reviewers: labath, mgorny
Reviewed By: labath
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D69532
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/python_api/file_handle')
| -rw-r--r-- | lldb/packages/Python/lldbsuite/test/python_api/file_handle/TestFileHandle.py | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/lldb/packages/Python/lldbsuite/test/python_api/file_handle/TestFileHandle.py b/lldb/packages/Python/lldbsuite/test/python_api/file_handle/TestFileHandle.py index f7f1ad08500..5d025a46dce 100644 --- a/lldb/packages/Python/lldbsuite/test/python_api/file_handle/TestFileHandle.py +++ b/lldb/packages/Python/lldbsuite/test/python_api/file_handle/TestFileHandle.py @@ -851,10 +851,6 @@ class FileHandleTestCase(lldbtest.TestBase): yield sbf sbf.Write(str(i).encode('ascii') + b"\n") files = list(i(sbf)) - # delete them in reverse order, again because each is a borrow - # of the previous. - while files: - files.pop() with open(self.out_filename, 'r') as f: self.assertEqual(list(range(10)), list(map(int, f.read().strip().split()))) |
