summaryrefslogtreecommitdiffstats
path: root/lldb/packages/Python/lldbsuite/test/macosx/universal
diff options
context:
space:
mode:
authorAdrian Prantl <aprantl@apple.com>2018-01-30 18:29:16 +0000
committerAdrian Prantl <aprantl@apple.com>2018-01-30 18:29:16 +0000
commit5ec76fe720e43a9196d3437e1ff448668bf7db6d (patch)
tree49d569898f53e6887e7167b4470b5e672ddf1541 /lldb/packages/Python/lldbsuite/test/macosx/universal
parent1d8e5ea2500728cfc751ce055dd75e5084584e9c (diff)
downloadbcm5719-llvm-5ec76fe720e43a9196d3437e1ff448668bf7db6d.tar.gz
bcm5719-llvm-5ec76fe720e43a9196d3437e1ff448668bf7db6d.zip
Compile the LLDB tests out-of-tree.
This patch is the result of a discussion on lldb-dev, see http://lists.llvm.org/pipermail/lldb-dev/2018-January/013111.html for background. For each test (should be eventually: each test configuration) a separate build directory is created and we execute make VPATH=$srcdir/path/to/test -C $builddir/path/to/test -f $srcdir/path/to/test/Makefile -I $srcdir/path/to/test In order to make this work all LLDB tests need to be updated to find the executable in the test build directory, since CWD still points at the test's source directory, which is a requirement for unittest2. Although we have done extensive testing, I'm expecting that this first attempt will break a few bots. Please DO NOT HESITATE TO REVERT this patch in order to get the bots green again. We will likely have to iterate on this some more. Differential Revision: https://reviews.llvm.org/D42281 llvm-svn: 323803
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/macosx/universal')
-rw-r--r--lldb/packages/Python/lldbsuite/test/macosx/universal/Makefile12
-rw-r--r--lldb/packages/Python/lldbsuite/test/macosx/universal/TestUniversal.py6
2 files changed, 10 insertions, 8 deletions
diff --git a/lldb/packages/Python/lldbsuite/test/macosx/universal/Makefile b/lldb/packages/Python/lldbsuite/test/macosx/universal/Makefile
index 854c78ed8c2..d74ed26f50a 100644
--- a/lldb/packages/Python/lldbsuite/test/macosx/universal/Makefile
+++ b/lldb/packages/Python/lldbsuite/test/macosx/universal/Makefile
@@ -1,19 +1,21 @@
CC ?= clang
+all: testit
+
testit: testit.i386 testit.x86_64
- lipo -create -o testit testit.i386 testit.x86_64
+ lipo -create -o testit $^
testit.i386: testit.i386.o
- $(CC) -arch i386 -o testit.i386 testit.i386.o
+ $(CC) -arch i386 -o testit.i386 $<
testit.x86_64: testit.x86_64.o
- $(CC) -arch x86_64 -o testit.x86_64 testit.x86_64.o
+ $(CC) -arch x86_64 -o testit.x86_64 $<
testit.i386.o: main.c
- $(CC) -g -O0 -arch i386 -c -o testit.i386.o main.c
+ $(CC) -g -O0 -arch i386 -c -o testit.i386.o $<
testit.x86_64.o: main.c
- $(CC) -g -O0 -arch x86_64 -c -o testit.x86_64.o main.c
+ $(CC) -g -O0 -arch x86_64 -c -o testit.x86_64.o $<
clean:
rm -rf $(wildcard testit* *~)
diff --git a/lldb/packages/Python/lldbsuite/test/macosx/universal/TestUniversal.py b/lldb/packages/Python/lldbsuite/test/macosx/universal/TestUniversal.py
index 9a690e3ebb0..ca4f3ce9b13 100644
--- a/lldb/packages/Python/lldbsuite/test/macosx/universal/TestUniversal.py
+++ b/lldb/packages/Python/lldbsuite/test/macosx/universal/TestUniversal.py
@@ -33,7 +33,7 @@ class UniversalTestCase(TestBase):
self.build()
# Note that "testit" is a universal binary.
- exe = os.path.join(os.getcwd(), "testit")
+ exe = self.getBuildArtifact("testit")
# Create a target by the debugger.
target = self.dbg.CreateTargetWithFileAndTargetTriple(
@@ -57,7 +57,7 @@ class UniversalTestCase(TestBase):
self.build()
# Note that "testit" is a universal binary.
- exe = os.path.join(os.getcwd(), "testit")
+ exe = self.getBuildArtifact("testit")
# By default, x86_64 is assumed if no architecture is specified.
self.expect("file " + exe, CURRENT_EXECUTABLE_SET,
@@ -130,7 +130,7 @@ class UniversalTestCase(TestBase):
self.build()
# Note that "testit" is a universal binary.
- exe = os.path.join(os.getcwd(), "testit")
+ exe = self.getBuildArtifact("testit")
# Create a target by the debugger.
target = self.dbg.CreateTargetWithFileAndTargetTriple(
OpenPOWER on IntegriCloud