summaryrefslogtreecommitdiffstats
path: root/lldb/packages/Python/lldbsuite/test/lldbtest.py
diff options
context:
space:
mode:
authorPeter Collingbourne <peter@pcc.me.uk>2019-01-22 23:54:49 +0000
committerPeter Collingbourne <peter@pcc.me.uk>2019-01-22 23:54:49 +0000
commitbcd08c16bb7678d1ddf8d511188b310cabd74bc0 (patch)
tree2ee55e3d3e83892553f7ad5caa4f5bf5fad9e55c /lldb/packages/Python/lldbsuite/test/lldbtest.py
parent342611114580412d814ae435e1d1b37be22f86e8 (diff)
downloadbcm5719-llvm-bcd08c16bb7678d1ddf8d511188b310cabd74bc0.tar.gz
bcm5719-llvm-bcd08c16bb7678d1ddf8d511188b310cabd74bc0.zip
COFF, ELF: ICF: Perform 2 rounds of relocation hash propagation.
LLD's performance on PGO instrumented Windows binaries was still not great even with the fix in D56955; out of the 2m41s linker runtime, around 2 minutes were still being spent in ICF. I looked into this more closely and discovered that the vast majority of the runtime was being spent segregating .pdata sections with the following relocation chain: .pdata -> identical .text -> unique PGO counter (not eligible for ICF) This patch causes us to perform 2 rounds of relocation hash propagation, which allows the hash for the .pdata sections to incorporate the identifier from the PGO counter. With that, the amount of time spent in ICF was reduced to about 2 seconds. I also found that the same change led to a significant ICF performance improvement in a regular release build of Chromium's chrome_child.dll, where ICF time was reduced from around 1s to around 700ms. With the same change applied to the ELF linker, median of 100 runs for lld-speed-test/chrome reduced from 4.53s to 4.45s on my machine. I also experimented with increasing the number of propagation rounds further, but I did not observe any further significant performance improvements linking Chromium or Firefox. Differential Revision: https://reviews.llvm.org/D56986 llvm-svn: 351899
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/lldbtest.py')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud