summaryrefslogtreecommitdiffstats
path: root/lldb/packages/Python/lldbsuite/test/lldbtest.py
diff options
context:
space:
mode:
authorJan Kratochvil <jan.kratochvil@redhat.com>2019-06-17 14:46:17 +0000
committerJan Kratochvil <jan.kratochvil@redhat.com>2019-06-17 14:46:17 +0000
commit8c82c41262fad55de7ed921b9e0df0da6c0e896b (patch)
tree0cf18d293fff5476ad7cb87743367e85a3ea8263 /lldb/packages/Python/lldbsuite/test/lldbtest.py
parent15b7f5b72d2ae3dae37a42caa8d3259cfafc70c6 (diff)
downloadbcm5719-llvm-8c82c41262fad55de7ed921b9e0df0da6c0e896b.tar.gz
bcm5719-llvm-8c82c41262fad55de7ed921b9e0df0da6c0e896b.zip
[lldb] [test] Extend D55859 symbols.enable-external-lookup=false for more testcases
D55859 <https://reviews.llvm.org/D55859> has no effect for some of the testcases so this patch extends it even for (all?) other testcases known to me. LLDB was failing when LLDB prints errors reading system debug infos (`*-debuginfo.rpm`, DWZ-optimized) which should never happen as LLDB testcases should not be affected by system debug infos. `lldb/packages/Python/lldbsuite/test/api/multithreaded/driver.cpp.template` is using only SB API which does not expose `ModuleList` so I had to call `HandleCommand()` there. `lldb-test.cpp` could also use `HandleCommand` and then there would be no need for `ModuleListProperties::SetEnableExternalLookup()` but I think it is cleaner with API and not on based on text commands. Differential Revision: https://reviews.llvm.org/D63339 llvm-svn: 363567
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/lldbtest.py')
-rw-r--r--lldb/packages/Python/lldbsuite/test/lldbtest.py8
1 files changed, 4 insertions, 4 deletions
diff --git a/lldb/packages/Python/lldbsuite/test/lldbtest.py b/lldb/packages/Python/lldbsuite/test/lldbtest.py
index 90588a6e6b7..3064a6c2d85 100644
--- a/lldb/packages/Python/lldbsuite/test/lldbtest.py
+++ b/lldb/packages/Python/lldbsuite/test/lldbtest.py
@@ -729,12 +729,12 @@ class Base(unittest2.TestCase):
else:
self.lldbVSCodeExec = None
+ self.lldbOption = "-o 'settings set symbols.enable-external-lookup false'"
+
# If we spawn an lldb process for test (via pexpect), do not load the
# init file unless told otherwise.
- if "NO_LLDBINIT" in os.environ and "NO" == os.environ["NO_LLDBINIT"]:
- self.lldbOption = ""
- else:
- self.lldbOption = "--no-lldbinit"
+ if os.environ.get("NO_LLDBINIT") != "NO":
+ self.lldbOption += " --no-lldbinit"
# Assign the test method name to self.testMethodName.
#
OpenPOWER on IntegriCloud