diff options
| author | James Y Knight <jyknight@google.com> | 2019-02-06 00:06:03 +0000 |
|---|---|---|
| committer | James Y Knight <jyknight@google.com> | 2019-02-06 00:06:03 +0000 |
| commit | ab4f7f144a633329fb8f619c4133d69606dd0d2a (patch) | |
| tree | 612fb2b73b97e2c9f241b3a09be205cc4f03b3cb /lldb/packages/Python/lldbsuite/test/lang/cpp | |
| parent | b9c1bc6d3cb1159470169f2d74cfec548c54b736 (diff) | |
| download | bcm5719-llvm-ab4f7f144a633329fb8f619c4133d69606dd0d2a.tar.gz bcm5719-llvm-ab4f7f144a633329fb8f619c4133d69606dd0d2a.zip | |
Fix MSVC constructor call extension after b92d290e48e9 (r353181).
The assert added to EmitCall there was triggering in Windows Chromium
builds, due to a mismatch of the return type.
The MSVC constructor call extension (`this->Foo::Foo()`) was emitting
the constructor call from 'EmitCXXMemberOrOperatorMemberCallExpr' via
calling 'EmitCXXMemberOrOperatorCall', instead of
'EmitCXXConstructorCall'. On targets where HasThisReturn is true, that
was failing to set the proper return type in the call info.
Switching to calling EmitCXXConstructorCall also allowed removing some
code e.g. the trivial copy/move support, which is already handled in
EmitCXXConstructorCall.
Ref: https://bugs.chromium.org/p/chromium/issues/detail?id=928861
Differential Revision: https://reviews.llvm.org/D57794
llvm-svn: 353246
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/lang/cpp')
0 files changed, 0 insertions, 0 deletions
