summaryrefslogtreecommitdiffstats
path: root/lldb/packages/Python/lldbsuite/test/lang/cpp/scope
diff options
context:
space:
mode:
authorVedant Kumar <vsk@apple.com>2019-02-15 18:46:58 +0000
committerVedant Kumar <vsk@apple.com>2019-02-15 18:46:58 +0000
commit5f5cac3ae29d44869f64d9629d9443656199fc1d (patch)
tree0542e88813f57a5604aebe6b6962c80791b1f9b7 /lldb/packages/Python/lldbsuite/test/lang/cpp/scope
parent47a0c9b69cd7aaebbbf9c9b6b86e37fa892a6191 (diff)
downloadbcm5719-llvm-5f5cac3ae29d44869f64d9629d9443656199fc1d.tar.gz
bcm5719-llvm-5f5cac3ae29d44869f64d9629d9443656199fc1d.zip
[CodeExtractor] Do not lift lifetime.end markers for region inputs
If a lifetime.end marker occurs along one path through the extraction region, but not another, then it's still incorrect to lift the marker, because there is some path through the extracted function which would ordinarily not reach the marker. If the call to the extracted function is in a loop, unrolling can cause inputs to the function to become optimized out as undef after the first iteration. To prevent incorrect stack slot merging in the calling function, it should be sufficient to lift lifetime.start markers for region inputs. I've tested this theory out by doing a stage2 check-all with randomized splitting enabled. This is a follow-up to r353973, and there's additional context for this change in https://reviews.llvm.org/D57834. rdar://47896986 Differential Revision: https://reviews.llvm.org/D58253 llvm-svn: 354159
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/lang/cpp/scope')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud