diff options
author | Shafik Yaghmour <syaghmour@apple.com> | 2019-05-01 16:39:31 +0000 |
---|---|---|
committer | Shafik Yaghmour <syaghmour@apple.com> | 2019-05-01 16:39:31 +0000 |
commit | c3dd67204c92a6456fb30bd9d59776efa2be197f (patch) | |
tree | f66b6ead2edcdaad927a48ba6b308e3e1f89c3e5 /lldb/packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack | |
parent | 692560dc986d90930887c0313249bc9fff798bf8 (diff) | |
download | bcm5719-llvm-c3dd67204c92a6456fb30bd9d59776efa2be197f.tar.gz bcm5719-llvm-c3dd67204c92a6456fb30bd9d59776efa2be197f.zip |
Disabling test in TestClassTemplateParameterPack.py until we do template lookup correctly
Summary:
Some tests currently only work because we are pulling all the local variables when we are evaluating an expression. This will soon
change and these test are working but for the wrong reasons. The details can be found in the discussion here:
http://lists.llvm.org/pipermail/lldb-commits/Week-of-Mon-20180507/040689.html
Differential Review: https://reviews.llvm.org/D61266
llvm-svn: 359699
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack')
2 files changed, 9 insertions, 7 deletions
diff --git a/lldb/packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/TestClassTemplateParameterPack.py b/lldb/packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/TestClassTemplateParameterPack.py index 5e5b72d3568..7e67f73b709 100644 --- a/lldb/packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/TestClassTemplateParameterPack.py +++ b/lldb/packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/TestClassTemplateParameterPack.py @@ -4,6 +4,4 @@ from lldbsuite.test import decorators lldbinline.MakeInlineTest( __file__, globals(), [ decorators.expectedFailureAll( - compiler="gcc"), - # rdar://problem/48128064 - decorators.skipIfDarwin]) + compiler="gcc")]) diff --git a/lldb/packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/main.cpp b/lldb/packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/main.cpp index 1f25b0206b3..9278d01f8c5 100644 --- a/lldb/packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/main.cpp +++ b/lldb/packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/main.cpp @@ -42,10 +42,12 @@ int main (int argc, char const *argv[]) (void)C<int,16,32>().isSixteenThirtyTwo(); (void)C<int,16>().isSixteenThirtyTwo(); (void)(myC.member != 64); //% self.expect("expression -- myC", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["64"]) - //% self.expect("expression -- C<int, 16>().isSixteenThirtyTwo()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["false"]) - //% self.expect("expression -- C<int, 16, 32>().isSixteenThirtyTwo()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["true"]) //% self.expect("expression -- myLesserC.isSixteenThirtyTwo()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["false"]) //% self.expect("expression -- myC.isSixteenThirtyTwo()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["true"]) + + // Disabling until we do template lookup correctly: http://lists.llvm.org/pipermail/lldb-commits/Week-of-Mon-20180507/040689.html + //#% self.expect("expression -- C<int, 16>().isSixteenThirtyTwo()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["false"]) + //#% self.expect("expression -- C<int, 16, 32>().isSixteenThirtyTwo()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["true"]) D<int,int,bool> myD; D<int,int> myLesserD; @@ -53,8 +55,10 @@ int main (int argc, char const *argv[]) (void)D<int,int,bool>().isIntBool(); (void)D<int,int>().isIntBool(); return myD.member != 64; //% self.expect("expression -- myD", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["64"]) - //% self.expect("expression -- D<int, int>().isIntBool()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["false"]) - //% self.expect("expression -- D<int, int, bool>().isIntBool()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["true"]) //% self.expect("expression -- myLesserD.isIntBool()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["false"]) //% self.expect("expression -- myD.isIntBool()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["true"]) + + // See comment above. + //#% self.expect("expression -- D<int, int>().isIntBool()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["false"]) + //#% self.expect("expression -- D<int, int, bool>().isIntBool()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["true"]) } |