diff options
author | Sam McCall <sam.mccall@gmail.com> | 2017-12-20 16:06:05 +0000 |
---|---|---|
committer | Sam McCall <sam.mccall@gmail.com> | 2017-12-20 16:06:05 +0000 |
commit | 328cbdb9e4be6a2f61cc6017adda8a6ac2f36dab (patch) | |
tree | a25504f15a129d602c7952e4503ae140dbd5ad32 /lldb/packages/Python/lldbsuite/test/lang/cpp/call-function/main.cpp | |
parent | b1c9dbdd7da6156cae4f4eced3e43cd20850f631 (diff) | |
download | bcm5719-llvm-328cbdb9e4be6a2f61cc6017adda8a6ac2f36dab.tar.gz bcm5719-llvm-328cbdb9e4be6a2f61cc6017adda8a6ac2f36dab.zip |
[clangd] Switch xrefs and documenthighlight to annotated-code unit tests. NFC
Summary:
The goal here is again to make it easier to read and write the tests.
I've extracted `parseTextMarker` from CodeCompleteTests into an `Annotations`
class, adding features to it:
- as well as points `^s` it allows ranges `[[...]]`
- multiple points and ranges are supported
- points and ranges may be named: `$name^` and `$name[[...]]`
These features are used for the xrefs tests. This also paves the way for
replacing the lit diagnostics.test with more readable unit tests, using named
ranges.
Alternative considered: `TestSelectionRange` in clang-refactor/TestSupport
Main problems were:
- delimiting the end of ranges is awkward, requiring counting
- comment syntax is long and at least as cryptic for most cases
- no separate syntax for point vs range, which keeps xrefs tests concise
- Still need to convert to Position everywhere
- Still need helpers for common case of expecting exactly one point/range
(I'll probably promote the extra `PrintTo`s from some of the core Protocol types
into `operator<<` in `Protocol.h` itself in a separate, prior patch...)
Reviewers: ioeric
Subscribers: klimek, mgorny, ilya-biryukov, cfe-commits
Differential Revision: https://reviews.llvm.org/D41432
llvm-svn: 321184
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/lang/cpp/call-function/main.cpp')
0 files changed, 0 insertions, 0 deletions