diff options
author | Adrian Prantl <aprantl@apple.com> | 2018-04-30 21:54:02 +0000 |
---|---|---|
committer | Adrian Prantl <aprantl@apple.com> | 2018-04-30 21:54:02 +0000 |
commit | ce05952943d958c984cbd9fdbd45036e4c1cd6be (patch) | |
tree | 0c369bd2a2da5b75c18138d9f2a795336d97f133 /lldb/packages/Python/lldbsuite/test/help/TestHelp.py | |
parent | 32f2d0e5643b5ab58486810050320a678862ae04 (diff) | |
download | bcm5719-llvm-ce05952943d958c984cbd9fdbd45036e4c1cd6be.tar.gz bcm5719-llvm-ce05952943d958c984cbd9fdbd45036e4c1cd6be.zip |
Remove premature caching of the global variables list in CompileUnit.
This fixes a bug where
(lldb) target var g_ptr
would populate the global variables list with exactly one entry
because SymbolFileDWARF::ParseVariables() was invoked with a list of
DIEs pre-filtered by name, such that a subsequent call to
(lldb) fr var --show-globals
would only list that one variable, because CompileUnit::m_variables
was already initialized, fooling CompileUnit::GetVariableList().
CompileUnit::GetVariableList() grabs the *complete* list of variables
via (SymbolFileDWARF, ...)::ParseVariablesForContext and that still
calls CompileUnit::SetVariableList(variables) which acts as the
caching mechanism.
Differential Revision: https://reviews.llvm.org/D46220
llvm-svn: 331230
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/help/TestHelp.py')
0 files changed, 0 insertions, 0 deletions