diff options
| author | Sam McCall <sam.mccall@gmail.com> | 2018-10-04 17:18:55 +0000 |
|---|---|---|
| committer | Sam McCall <sam.mccall@gmail.com> | 2018-10-04 17:18:55 +0000 |
| commit | 50b89f0a9b584307a300d95ebba65b49b1e968d2 (patch) | |
| tree | b408e3e9927aaa04898d1235a50c9b1c84ed4af0 /lldb/packages/Python/lldbsuite/test/functionalities/target_command/TestTargetCommand.py | |
| parent | aa728f1afa30afbd6aa4c0d9b2712c4e78f66cbe (diff) | |
| download | bcm5719-llvm-50b89f0a9b584307a300d95ebba65b49b1e968d2.tar.gz bcm5719-llvm-50b89f0a9b584307a300d95ebba65b49b1e968d2.zip | |
[clangd] Simplify Dex query tree logic and fix missing-posting-list bug
Summary:
The bug being fixed: when a posting list doesn't exist in the index, it
was previously just dropped from the query rather than being treated as
empty. Now that we have the FALSE iterator, we can use it instead.
The query tree logic previously had a bunch of special cases to detect whether
subtrees are empty. Now we just naively build the whole tree, and rely
on the query optimizations to drop the trivial parts.
Finally, there was a bug in trigram generation: the empty query would
generate a single trigram "$$$" instead of no trigrams.
This had no effect (there was no posting list, so the other bug
cancelled it out). But we now have to fix this bug too.
Reviewers: ilya-biryukov
Subscribers: ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits
Differential Revision: https://reviews.llvm.org/D52796
llvm-svn: 343802
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/functionalities/target_command/TestTargetCommand.py')
0 files changed, 0 insertions, 0 deletions
