summaryrefslogtreecommitdiffstats
path: root/lldb/packages/Python/lldbsuite/test/functionalities/stop-hook/multiple_threads
diff options
context:
space:
mode:
authorZachary Turner <zturner@google.com>2015-12-08 01:15:30 +0000
committerZachary Turner <zturner@google.com>2015-12-08 01:15:30 +0000
commit606e3a5221ec611a2f5da6d9a4961e8e2199f9d2 (patch)
treea71b819581216c1153340efce0baafd6a7da6941 /lldb/packages/Python/lldbsuite/test/functionalities/stop-hook/multiple_threads
parentda30cff9ef2e22cf9e8e307f132976a15feacdf8 (diff)
downloadbcm5719-llvm-606e3a5221ec611a2f5da6d9a4961e8e2199f9d2.tar.gz
bcm5719-llvm-606e3a5221ec611a2f5da6d9a4961e8e2199f9d2.zip
Get rid of global variables in dotest.py
This moves all the global variables into a separate module called `configuration`. This has a number of advantages: 1. Configuration data is centrally maintained so it's easy to get a high level overview of what configuration data the test suite makes use of. 2. The method of sharing configuration data among different parts of the test suite becomes standardized. Previously we would put some things into the `lldb` module, some things into the `lldbtest_config` module, and some things would not get shared. Now everything is shared through one module and is available to the entire test suite. 3. It opens the door to moving some of the initialization code into the `configuration` module, simplifying the implementation of `dotest.py`. There are a few stragglers that didn't get converted over to using the `configuration` module in this patch, because it would have grown the size of the patch unnecessarily. This includes everything currently in the `lldbtest_config` module, as well as the `lldb.remote_platform` variable. We can address these in the future. llvm-svn: 254982
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/functionalities/stop-hook/multiple_threads')
-rw-r--r--lldb/packages/Python/lldbsuite/test/functionalities/stop-hook/multiple_threads/TestStopHookMultipleThreads.py5
1 files changed, 3 insertions, 2 deletions
diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/stop-hook/multiple_threads/TestStopHookMultipleThreads.py b/lldb/packages/Python/lldbsuite/test/functionalities/stop-hook/multiple_threads/TestStopHookMultipleThreads.py
index 88ea847d682..c7fb53d495e 100644
--- a/lldb/packages/Python/lldbsuite/test/functionalities/stop-hook/multiple_threads/TestStopHookMultipleThreads.py
+++ b/lldb/packages/Python/lldbsuite/test/functionalities/stop-hook/multiple_threads/TestStopHookMultipleThreads.py
@@ -8,6 +8,7 @@ from __future__ import print_function
import os, time
import lldb
+from lldbsuite.test import configuration
from lldbsuite.test.lldbtest import *
class StopHookForMultipleThreadsTestCase(TestBase):
@@ -49,9 +50,9 @@ class StopHookForMultipleThreadsTestCase(TestBase):
child.expect_exact(prompt)
child.sendline('platform select %s' % lldb.remote_platform.GetName())
child.expect_exact(prompt)
- child.sendline('platform connect %s' % lldb.platform_url)
+ child.sendline('platform connect %s' % configuration.lldb_platform_url)
child.expect_exact(prompt)
- child.sendline('platform settings -w %s' % lldb.remote_platform_working_dir)
+ child.sendline('platform settings -w %s' % configuration.lldb_platform_working_dir)
child.expect_exact(prompt)
child.sendline('target create %s' % exe)
OpenPOWER on IntegriCloud