diff options
author | Heejin Ahn <aheejin@gmail.com> | 2019-08-26 21:51:35 +0000 |
---|---|---|
committer | Heejin Ahn <aheejin@gmail.com> | 2019-08-26 21:51:35 +0000 |
commit | 173a3a54bba06ffbf2b680cf52f1f8a257c33b15 (patch) | |
tree | 07ba56303aca951130917b03c347b92c891a1561 /lldb/packages/Python/lldbsuite/test/functionalities/command_source | |
parent | ed4fefb0df94799d902fadeabef4161f729ff8ca (diff) | |
download | bcm5719-llvm-173a3a54bba06ffbf2b680cf52f1f8a257c33b15.tar.gz bcm5719-llvm-173a3a54bba06ffbf2b680cf52f1f8a257c33b15.zip |
[WebAssembly] Fix SSA rebuilding in SjLj transformation
Summary:
Previously we skipped uses within the same BB as a def when rebuilding
SSA after SjLj transformation. For example, before transformation,
```
for.cond:
%0 = phi i32 [ %var, %for.inc ] ...
%var = ...
br label %for.inc
for.inc: ; preds = %for.cond
call i32 @setjmp(...)
br %for.cond
```
In this BB, %var should be defined in all paths from %for.inc to make %0
valid. In the input it was true; %for.inc's only predecessor was
%for.cond. But after SjLj transformation, it is possible that %for.inc
has other predecessors that are reachable without reaching %for.cond.
```
entry.split:
...
br i1 %a, label %bb.1, label %for.inc
for.cond:
%0 = phi i32 [ %var, %for.inc ] ... ; Not valid!
%var = ...
br label %for.inc
for.inc: ; preds = %for.cond, %entry.split
call i32 @setjmp(...)
...
br %for.cond
```
In this case, we can't use %var in the `phi` instruction in %for.cond,
because %var is not defined in all paths through %for.inc (If the
control flow is %entry -> %entry.split -> %for.inc -> %for.cond, %var
has not been defined until we reach the `phi`). But the previous code
excluded users within the same BB, skipping instructions within the same
BB so they are not rewritten properly. User instructions within the same
BB also should be candidates for rewriting if they are _before_ the
original definition.
Fixes PR43097.
Reviewers: dschuff
Subscribers: sbc100, jgravelle-google, hiraditya, sunfish, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66729
llvm-svn: 369978
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/functionalities/command_source')
0 files changed, 0 insertions, 0 deletions