diff options
| author | Pavel Labath <labath@google.com> | 2017-02-27 11:05:34 +0000 |
|---|---|---|
| committer | Pavel Labath <labath@google.com> | 2017-02-27 11:05:34 +0000 |
| commit | 6ac8403430c33aebdd88e5fa41921bc65265d180 (patch) | |
| tree | 833b11ce72ddb5356ba62cea361ce68fb8e98ffe /lldb/packages/Python/lldbsuite/test/functionalities/breakpoint | |
| parent | 6d171006f4a236cb417834f16ddff838433b7c46 (diff) | |
| download | bcm5719-llvm-6ac8403430c33aebdd88e5fa41921bc65265d180.tar.gz bcm5719-llvm-6ac8403430c33aebdd88e5fa41921bc65265d180.zip | |
Switch SBBreakpoint to storing a weak_ptr of the internal breakpoint object
Summary:
There is nothing we can do with the breakpoint once the associated
target becomes deleted. This will make sure we don't hold on to more
resources than we need in this case. In particular, this fixes the case
TestStepOverBreakpoint on windows, where a lingering SBBreakpoint object
causes us to nor unmap the executable file from memory.
Reviewers: clayborg, jingham
Subscribers: lldb-commits
Differential Revision: https://reviews.llvm.org/D30249
llvm-svn: 296328
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/functionalities/breakpoint')
| -rw-r--r-- | lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/step_over_breakpoint/TestStepOverBreakpoint.py | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/step_over_breakpoint/TestStepOverBreakpoint.py b/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/step_over_breakpoint/TestStepOverBreakpoint.py index 7bc5e1e5da0..00ddc628607 100644 --- a/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/step_over_breakpoint/TestStepOverBreakpoint.py +++ b/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/step_over_breakpoint/TestStepOverBreakpoint.py @@ -52,7 +52,6 @@ class StepOverBreakpointsTestCase(TestBase): self.thread = lldbutil.get_one_thread_stopped_at_breakpoint(self.process, self.breakpoint1) self.assertIsNotNone(self.thread, "Didn't stop at breakpoint 1.") - @skipIf(bugnumber="llvm.org/pr31972", hostoslist=["windows"]) def test_step_instruction(self): # Count instructions between breakpoint_1 and breakpoint_4 contextList = self.target.FindFunctions('main', lldb.eFunctionNameTypeAuto) |
