diff options
| author | Adrian McCarthy <amccarth@google.com> | 2018-02-21 18:08:23 +0000 |
|---|---|---|
| committer | Adrian McCarthy <amccarth@google.com> | 2018-02-21 18:08:23 +0000 |
| commit | 25727a458ce42292d73af5c692d6e12d06500e68 (patch) | |
| tree | cf0722ff014e823b9fb44bd30613da9d89684ca9 /lldb/packages/Python/lldbsuite/test/functionalities/breakpoint | |
| parent | 6b287234ea0a8d5a5533a1b687c1cbaddffa6404 (diff) | |
| download | bcm5719-llvm-25727a458ce42292d73af5c692d6e12d06500e68.tar.gz bcm5719-llvm-25727a458ce42292d73af5c692d6e12d06500e68.zip | |
Fix TestBreakpointInGlobalConstructor for Windows
Summary:
This test was failing on Windows because it expected the breakpoint in the
dynamic library to be resolved before the process is launched. Since the DLL
isn't loaded until the process is launched this didn't work.
The fix creates a special value (-2) for num_expected_locations that ignores
the actual number of breakpoint locations found.
Reviewers: jasonmolenda
Subscribers: sanjoy, lldb-commits
Differential Revision: https://reviews.llvm.org/D43419
llvm-svn: 325704
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/functionalities/breakpoint')
| -rw-r--r-- | lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/TestBreakpointInGlobalConstructor.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/TestBreakpointInGlobalConstructor.py b/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/TestBreakpointInGlobalConstructor.py index 5f0e7a058a4..9551ab278eb 100644 --- a/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/TestBreakpointInGlobalConstructor.py +++ b/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/TestBreakpointInGlobalConstructor.py @@ -29,8 +29,9 @@ class TestBreakpointInGlobalConstructors(TestBase): bp_main = lldbutil.run_break_set_by_file_and_line( self, 'main.cpp', self.line_main) + bp_foo = lldbutil.run_break_set_by_file_and_line( - self, 'foo.cpp', self.line_foo) + self, 'foo.cpp', self.line_foo, num_expected_locations=-2) process = target.LaunchSimple( None, env, self.get_process_working_directory()) |
