diff options
| author | Fangrui Song <maskray@google.com> | 2019-05-14 14:37:26 +0000 |
|---|---|---|
| committer | Fangrui Song <maskray@google.com> | 2019-05-14 14:37:26 +0000 |
| commit | 2f6ef2fc92955a5b77f302294ba97aa51dbaec4c (patch) | |
| tree | ef0f21f435a5e3dae07675ad4bf93de4a529f6b7 /lldb/packages/Python/lldbsuite/test/expression_command/inline-namespace/main.cpp | |
| parent | 22561972af4793ccf156aa2425adfd1daeabf6c6 (diff) | |
| download | bcm5719-llvm-2f6ef2fc92955a5b77f302294ba97aa51dbaec4c.tar.gz bcm5719-llvm-2f6ef2fc92955a5b77f302294ba97aa51dbaec4c.zip | |
DWARF v5: emit DW_AT_addr_base if DW_AT_low_pc references .debug_addr
The condition !AddrPool.empty() is tested before attachRangesOrLowHighPC(), which may add an entry to AddrPool. We emit DW_AT_low_pc (DW_FORM_addrx) but may incorrectly omit DW_AT_addr_base for LineTablesOnly. This can be easily reproduced:
clang -gdwarf-5 -gmlt -c a.cc
Fix this by moving !AddrPool.empty() below.
This was discovered while investigating an lld crash (fixed by D61889) on such object files: ld.lld --gdb-index a.o
Reviewed By: probinson
Differential Revision: https://reviews.llvm.org/D61891
llvm-svn: 360678
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/expression_command/inline-namespace/main.cpp')
0 files changed, 0 insertions, 0 deletions
