diff options
author | Jordan Rose <jordan_rose@apple.com> | 2019-07-18 20:05:11 +0000 |
---|---|---|
committer | Jordan Rose <jordan_rose@apple.com> | 2019-07-18 20:05:11 +0000 |
commit | 887d31cceee27ffa9162486a86301a925f9c1d54 (patch) | |
tree | 630c90c1621e59d1d00779613afa749b697ee4c2 /lldb/packages/Python/lldbsuite/test/expression_command/context-object/TestContextObject.py | |
parent | 9e52d0576ab7e6a3973f550b347b7f91c79d2521 (diff) | |
download | bcm5719-llvm-887d31cceee27ffa9162486a86301a925f9c1d54.tar.gz bcm5719-llvm-887d31cceee27ffa9162486a86301a925f9c1d54.zip |
FileSystem: Check for DTTOIF alone, not _DIRENT_HAVE_D_TYPE
While 'd_type' is a non-standard extension to `struct dirent`, only
glibc signals its presence with a macro '_DIRENT_HAVE_D_TYPE'.
However, any platform with 'd_type' also includes a way to convert to
mode_t values using the macro 'DTTOIF', so we can check for that alone
and still be confident that the 'd_type' member exists.
(If this turns out to be wrong, I'll go back and set up an actual
CMake check.)
I couldn't think of how to write a test for this, because I couldn't
think of how to test that a 'stat' call doesn't happen without
controlling the filesystem or intercepting 'stat', and there's no good
cross-platform way to do that that I know of.
Follow-up (almost a year later) to r342089.
rdar://problem/50592673
https://reviews.llvm.org/D64940
llvm-svn: 366486
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/expression_command/context-object/TestContextObject.py')
0 files changed, 0 insertions, 0 deletions