diff options
| author | Pavel Labath <pavel@labath.sk> | 2019-04-29 10:55:22 +0000 |
|---|---|---|
| committer | Pavel Labath <pavel@labath.sk> | 2019-04-29 10:55:22 +0000 |
| commit | b07a7997520f9681464e788837f7f5ce5fa38180 (patch) | |
| tree | 9dbf5151ea0d6aa1f693c247b08fca7cb7e46181 /lldb/packages/Python/lldbsuite/test/expression_command/completion/TestExprCompletion.py | |
| parent | 46128cdf084a66f0815ba2045cbcd7ac9c3a6716 (diff) | |
| download | bcm5719-llvm-b07a7997520f9681464e788837f7f5ce5fa38180.tar.gz bcm5719-llvm-b07a7997520f9681464e788837f7f5ce5fa38180.zip | |
DWARFExpression: Fix implementation of DW_OP_pick
Summary:
The DWARF spec states that the DWARF stack arguments are numbered from
the top. Our implementation of DW_OP_pick was counting them from the
bottom.
This bug probably wasn't noticed because nobody (except my upcoming
postfix-to-DWARF converter) uses DW_OP_pick, but I've cross-checked with
gdb to confirm that counting from the top is the expected behavior.
This patch fixes the implementation to match the spec and gdb behavior
and adds a test.
Reviewers: jasonmolenda, clayborg
Subscribers: mgorny, aprantl, lldb-commits
Differential Revision: https://reviews.llvm.org/D61182
llvm-svn: 359436
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/expression_command/completion/TestExprCompletion.py')
0 files changed, 0 insertions, 0 deletions
