diff options
| author | Reid Kleckner <rnk@google.com> | 2019-07-16 18:17:33 +0000 |
|---|---|---|
| committer | Reid Kleckner <rnk@google.com> | 2019-07-16 18:17:33 +0000 |
| commit | fe44a531e0e2aba07213442b1930369316a112b0 (patch) | |
| tree | 81ab71660ce8f300a4075bec5013060def3a6409 /lldb/packages/Python/lldbsuite/test/expression_command/call-function/TestCallUserDefinedFunction.py | |
| parent | 35c96598b1246ea038677d7c4580f3c758ff1d93 (diff) | |
| download | bcm5719-llvm-fe44a531e0e2aba07213442b1930369316a112b0.tar.gz bcm5719-llvm-fe44a531e0e2aba07213442b1930369316a112b0.zip | |
[COFF] Implement /safeseh:no and check @feat.00 flags by default
Summary:
Fixes PR41828. Before this, LLD always emitted SafeSEH chunks and
defined __safe_se_handler_table & size. Now, /safeseh:no leaves those
undefined.
Additionally, we were checking for the safeseh @feat.00 flag in two
places: once to emit errors, and once during safeseh table construction.
The error was set up to be off by default, but safeseh is supposed to be
on by default. I combined the two checks, so now LLD emits an error if
an input object lacks @feat.00 and safeseh is enabled. This caused the
majority of 32-bit LLD tests to fail, since many test input object files
lack @feat.00 symbols. I explicitly added -safeseh:no to those tests to
preserve behavior.
Finally, LLD no longer sets IMAGE_DLL_CHARACTERISTICS_NO_SEH if any
input file wasn't compiled for safeseh.
Reviewers: mstorsjo, ruiu, thakis
Reviewed By: ruiu, thakis
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D63570
llvm-svn: 366238
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/expression_command/call-function/TestCallUserDefinedFunction.py')
0 files changed, 0 insertions, 0 deletions
