diff options
| author | Simon Pilgrim <llvm-dev@redking.me.uk> | 2018-08-15 20:41:19 +0000 |
|---|---|---|
| committer | Simon Pilgrim <llvm-dev@redking.me.uk> | 2018-08-15 20:41:19 +0000 |
| commit | c3c1441bda8a68e58b2d7e2a30e0a0d1e7164337 (patch) | |
| tree | 3d471bd95d50ce8bb708e5cb28b6b36a7d9ccafc /lldb/packages/Python/lldbsuite/test/expression_command/call-function/TestCallUserDefinedFunction.py | |
| parent | 22f01268fe2186d74a4de49a017ce1e2676fcb77 (diff) | |
| download | bcm5719-llvm-c3c1441bda8a68e58b2d7e2a30e0a0d1e7164337.tar.gz bcm5719-llvm-c3c1441bda8a68e58b2d7e2a30e0a0d1e7164337.zip | |
[TableGen] Remove unnecessary TypeSetByHwMode -> ValueTypeByHwMode -> TypeSetByHwMode conversions in getPatternSize
I noticed this during profiling of tablegen (PR28222) that we were calling Child->getType(0) which creates a ValueTypeByHwMode on the fly from the requested internal TypeSetByHwMode type and returns it by value, we then treat it as a TypeSetByHwMode reference which involves constructing a new TypeSetByHwMode on the stack with a large amount of std::map iterating/copying all along the way.
I am not an expert on tablegen, but AFAICT this is all unnecessary and we should be calling Child->getExtType(0) which returns the original TypeSetByHwMode by reference.
This gives me a 90sec reduction in msvc debug builds of x86 -gen-dag-isel.
Differential Revision: https://reviews.llvm.org/D50789
llvm-svn: 339812
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/expression_command/call-function/TestCallUserDefinedFunction.py')
0 files changed, 0 insertions, 0 deletions
