summaryrefslogtreecommitdiffstats
path: root/lldb/packages/Python/lldbsuite/test/commands
diff options
context:
space:
mode:
authorRaphael Isemann <teemperor@gmail.com>2019-12-13 12:24:23 +0100
committerRaphael Isemann <teemperor@gmail.com>2019-12-13 12:34:49 +0100
commit9bace26a690a778ec0f09a9aae9537dfbdb6f42f (patch)
tree4164aae25028a4490b310022d51a2ad36746079c /lldb/packages/Python/lldbsuite/test/commands
parent3ca771ba594fbd40da7ef842c04b5842e7b2a83c (diff)
downloadbcm5719-llvm-9bace26a690a778ec0f09a9aae9537dfbdb6f42f.tar.gz
bcm5719-llvm-9bace26a690a778ec0f09a9aae9537dfbdb6f42f.zip
[lldb][NFC] Remove all `setUp` overrides that only call the parent implementation
Summary: A lot of our tests copied the setUp code from our TestSampleTest.py: ``` def setUp(self): # Call super's setUp(). TestBase.setUp(self) ``` This code does nothing unless we actually do any setUp work in there, so let's remove all these method definitions. Reviewers: labath, JDevlieghere Reviewed By: labath Subscribers: lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D71454
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/commands')
-rw-r--r--lldb/packages/Python/lldbsuite/test/commands/apropos/basic/TestApropos.py3
-rw-r--r--lldb/packages/Python/lldbsuite/test/commands/command/script/import/TestImport.py4
-rw-r--r--lldb/packages/Python/lldbsuite/test/commands/command/script/import/rdar-12586188/TestRdar12586188.py4
-rw-r--r--lldb/packages/Python/lldbsuite/test/commands/disassemble/basic/TestFrameDisassemble.py4
-rw-r--r--lldb/packages/Python/lldbsuite/test/commands/expression/calculator_mode/TestCalculatorMode.py4
-rw-r--r--lldb/packages/Python/lldbsuite/test/commands/expression/dont_allow_jit/TestAllowJIT.py4
-rw-r--r--lldb/packages/Python/lldbsuite/test/commands/expression/entry-bp/TestExprEntryBP.py2
-rw-r--r--lldb/packages/Python/lldbsuite/test/commands/expression/persistent_ptr_update/TestPersistentPtrUpdate.py4
-rw-r--r--lldb/packages/Python/lldbsuite/test/commands/expression/weak_symbols/TestWeakSymbols.py4
-rw-r--r--lldb/packages/Python/lldbsuite/test/commands/frame/diagnose/array/TestArray.py3
-rw-r--r--lldb/packages/Python/lldbsuite/test/commands/frame/language/TestGuessLanguage.py4
-rw-r--r--lldb/packages/Python/lldbsuite/test/commands/frame/var/TestFrameVar.py4
-rw-r--r--lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/TestMPXRegisters.py3
-rw-r--r--lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/mpx_offset_intersection/TestMPXOffsetIntersection.py3
-rw-r--r--lldb/packages/Python/lldbsuite/test/commands/target/stop-hooks/TestStopHooks.py4
-rw-r--r--lldb/packages/Python/lldbsuite/test/commands/version/TestVersion.py3
-rw-r--r--lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_disable/TestWatchpointDisable.py4
17 files changed, 0 insertions, 61 deletions
diff --git a/lldb/packages/Python/lldbsuite/test/commands/apropos/basic/TestApropos.py b/lldb/packages/Python/lldbsuite/test/commands/apropos/basic/TestApropos.py
index c4337c7301f..920f0dd0b24 100644
--- a/lldb/packages/Python/lldbsuite/test/commands/apropos/basic/TestApropos.py
+++ b/lldb/packages/Python/lldbsuite/test/commands/apropos/basic/TestApropos.py
@@ -6,9 +6,6 @@ class AproposTestCase(TestBase):
mydir = TestBase.compute_mydir(__file__)
- def setUp(self):
- TestBase.setUp(self)
-
@no_debug_info_test
def test_apropos(self):
self.expect("apropos", error=True,
diff --git a/lldb/packages/Python/lldbsuite/test/commands/command/script/import/TestImport.py b/lldb/packages/Python/lldbsuite/test/commands/command/script/import/TestImport.py
index 9a96f78b922..a10c23bad1f 100644
--- a/lldb/packages/Python/lldbsuite/test/commands/command/script/import/TestImport.py
+++ b/lldb/packages/Python/lldbsuite/test/commands/command/script/import/TestImport.py
@@ -18,10 +18,6 @@ class ImportTestCase(TestBase):
"""Import some Python scripts by path and test them"""
self.run_test()
- def setUp(self):
- # Call super's setUp().
- TestBase.setUp(self)
-
def run_test(self):
"""Import some Python scripts by path and test them."""
diff --git a/lldb/packages/Python/lldbsuite/test/commands/command/script/import/rdar-12586188/TestRdar12586188.py b/lldb/packages/Python/lldbsuite/test/commands/command/script/import/rdar-12586188/TestRdar12586188.py
index ab48c21dd66..478cfa38d03 100644
--- a/lldb/packages/Python/lldbsuite/test/commands/command/script/import/rdar-12586188/TestRdar12586188.py
+++ b/lldb/packages/Python/lldbsuite/test/commands/command/script/import/rdar-12586188/TestRdar12586188.py
@@ -18,10 +18,6 @@ class Rdar12586188TestCase(TestBase):
"""Check that we handle an ImportError in a special way when command script importing files."""
self.run_test()
- def setUp(self):
- # Call super's setUp().
- TestBase.setUp(self)
-
def run_test(self):
"""Check that we handle an ImportError in a special way when command script importing files."""
diff --git a/lldb/packages/Python/lldbsuite/test/commands/disassemble/basic/TestFrameDisassemble.py b/lldb/packages/Python/lldbsuite/test/commands/disassemble/basic/TestFrameDisassemble.py
index 8e0cc963883..66f7891d9a8 100644
--- a/lldb/packages/Python/lldbsuite/test/commands/disassemble/basic/TestFrameDisassemble.py
+++ b/lldb/packages/Python/lldbsuite/test/commands/disassemble/basic/TestFrameDisassemble.py
@@ -20,10 +20,6 @@ class FrameDisassembleTestCase(TestBase):
self.build()
self.frame_disassemble_test()
- def setUp(self):
- # Call super's setUp().
- TestBase.setUp(self)
-
def frame_disassemble_test(self):
"""Sample test to ensure SBFrame::Disassemble produces SOME output"""
exe = self.getBuildArtifact("a.out")
diff --git a/lldb/packages/Python/lldbsuite/test/commands/expression/calculator_mode/TestCalculatorMode.py b/lldb/packages/Python/lldbsuite/test/commands/expression/calculator_mode/TestCalculatorMode.py
index 29d370e2335..f406066ace0 100644
--- a/lldb/packages/Python/lldbsuite/test/commands/expression/calculator_mode/TestCalculatorMode.py
+++ b/lldb/packages/Python/lldbsuite/test/commands/expression/calculator_mode/TestCalculatorMode.py
@@ -14,10 +14,6 @@ class TestCalculatorMode(TestBase):
mydir = TestBase.compute_mydir(__file__)
- def setUp(self):
- # Call super's setUp().
- TestBase.setUp(self)
-
def test__calculator_mode(self):
"""Test calling expressions in the dummy target."""
self.expect("expression 11 + 22", "11 + 22 didn't get the expected result", substrs=["33"])
diff --git a/lldb/packages/Python/lldbsuite/test/commands/expression/dont_allow_jit/TestAllowJIT.py b/lldb/packages/Python/lldbsuite/test/commands/expression/dont_allow_jit/TestAllowJIT.py
index 2babcc48cff..825e0be5b69 100644
--- a/lldb/packages/Python/lldbsuite/test/commands/expression/dont_allow_jit/TestAllowJIT.py
+++ b/lldb/packages/Python/lldbsuite/test/commands/expression/dont_allow_jit/TestAllowJIT.py
@@ -30,10 +30,6 @@ class TestAllowJIT(TestBase):
self.main_source_file = lldb.SBFileSpec("main.c")
self.expr_options_test()
- def setUp(self):
- # Call super's setUp().
- TestBase.setUp(self)
-
def expr_cmd_test(self):
(target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(self,
"Set a breakpoint here", self.main_source_file)
diff --git a/lldb/packages/Python/lldbsuite/test/commands/expression/entry-bp/TestExprEntryBP.py b/lldb/packages/Python/lldbsuite/test/commands/expression/entry-bp/TestExprEntryBP.py
index 56abc19f4f3..b6e6b8ba051 100644
--- a/lldb/packages/Python/lldbsuite/test/commands/expression/entry-bp/TestExprEntryBP.py
+++ b/lldb/packages/Python/lldbsuite/test/commands/expression/entry-bp/TestExprEntryBP.py
@@ -30,5 +30,3 @@ class ExprEntryBPTestCase(TestBase):
self.assertTrue(result.IsValid(), "Can't evaluate expression")
self.assertEqual(8, result.GetValueAsSigned())
- def setUp(self):
- TestBase.setUp(self)
diff --git a/lldb/packages/Python/lldbsuite/test/commands/expression/persistent_ptr_update/TestPersistentPtrUpdate.py b/lldb/packages/Python/lldbsuite/test/commands/expression/persistent_ptr_update/TestPersistentPtrUpdate.py
index 54cb4832312..5660113b8b4 100644
--- a/lldb/packages/Python/lldbsuite/test/commands/expression/persistent_ptr_update/TestPersistentPtrUpdate.py
+++ b/lldb/packages/Python/lldbsuite/test/commands/expression/persistent_ptr_update/TestPersistentPtrUpdate.py
@@ -13,10 +13,6 @@ class PersistentPtrUpdateTestCase(TestBase):
mydir = TestBase.compute_mydir(__file__)
- def setUp(self):
- # Call super's setUp().
- TestBase.setUp(self)
-
def test(self):
"""Test that we can have persistent pointer variables"""
self.build()
diff --git a/lldb/packages/Python/lldbsuite/test/commands/expression/weak_symbols/TestWeakSymbols.py b/lldb/packages/Python/lldbsuite/test/commands/expression/weak_symbols/TestWeakSymbols.py
index 21280ea3ae5..b58d838b14b 100644
--- a/lldb/packages/Python/lldbsuite/test/commands/expression/weak_symbols/TestWeakSymbols.py
+++ b/lldb/packages/Python/lldbsuite/test/commands/expression/weak_symbols/TestWeakSymbols.py
@@ -25,10 +25,6 @@ class TestWeakSymbolsInExpressions(TestBase):
self.main_source_file = lldb.SBFileSpec("main.c")
self.do_test()
- def setUp(self):
- # Call super's setUp().
- TestBase.setUp(self)
-
def run_weak_var_check (self, weak_varname, present):
# The expression will modify present_weak_int to signify which branch
# was taken. Set it to so we don't get confused by a previous run.
diff --git a/lldb/packages/Python/lldbsuite/test/commands/frame/diagnose/array/TestArray.py b/lldb/packages/Python/lldbsuite/test/commands/frame/diagnose/array/TestArray.py
index dca564c38a8..9b049a2bf2a 100644
--- a/lldb/packages/Python/lldbsuite/test/commands/frame/diagnose/array/TestArray.py
+++ b/lldb/packages/Python/lldbsuite/test/commands/frame/diagnose/array/TestArray.py
@@ -12,9 +12,6 @@ from lldbsuite.test import lldbutil
class TestArray(TestBase):
mydir = TestBase.compute_mydir(__file__)
- def setUp(self):
- TestBase.setUp(self)
-
@skipUnlessDarwin
@skipIfDarwinEmbedded # <rdar://problem/33842388> frame diagnose doesn't work for armv7 or arm64
def test_array(self):
diff --git a/lldb/packages/Python/lldbsuite/test/commands/frame/language/TestGuessLanguage.py b/lldb/packages/Python/lldbsuite/test/commands/frame/language/TestGuessLanguage.py
index 90b29baef45..2c8d1dd4709 100644
--- a/lldb/packages/Python/lldbsuite/test/commands/frame/language/TestGuessLanguage.py
+++ b/lldb/packages/Python/lldbsuite/test/commands/frame/language/TestGuessLanguage.py
@@ -26,10 +26,6 @@ class TestFrameGuessLanguage(TestBase):
self.build()
self.do_test()
- def setUp(self):
- # Call super's setUp().
- TestBase.setUp(self)
-
def check_language(self, thread, frame_no, test_lang):
frame = thread.frames[frame_no]
self.assertTrue(frame.IsValid(), "Frame %d was not valid."%(frame_no))
diff --git a/lldb/packages/Python/lldbsuite/test/commands/frame/var/TestFrameVar.py b/lldb/packages/Python/lldbsuite/test/commands/frame/var/TestFrameVar.py
index a9a9aa1da33..aa0f6b7e130 100644
--- a/lldb/packages/Python/lldbsuite/test/commands/frame/var/TestFrameVar.py
+++ b/lldb/packages/Python/lldbsuite/test/commands/frame/var/TestFrameVar.py
@@ -22,10 +22,6 @@ class TestFrameVar(TestBase):
self.build()
self.do_test()
- def setUp(self):
- # Call super's setUp().
- TestBase.setUp(self)
-
def do_test(self):
exe = self.getBuildArtifact("a.out")
diff --git a/lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/TestMPXRegisters.py b/lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/TestMPXRegisters.py
index 64099650b41..5644855868b 100644
--- a/lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/TestMPXRegisters.py
+++ b/lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/TestMPXRegisters.py
@@ -14,9 +14,6 @@ class RegisterCommandsTestCase(TestBase):
mydir = TestBase.compute_mydir(__file__)
- def setUp(self):
- TestBase.setUp(self)
-
@skipIf(compiler="clang")
@skipIf(oslist=no_match(['linux']))
@skipIf(archs=no_match(['i386', 'x86_64']))
diff --git a/lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/mpx_offset_intersection/TestMPXOffsetIntersection.py b/lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/mpx_offset_intersection/TestMPXOffsetIntersection.py
index 7b53d92836a..109e8e93404 100644
--- a/lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/mpx_offset_intersection/TestMPXOffsetIntersection.py
+++ b/lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/mpx_offset_intersection/TestMPXOffsetIntersection.py
@@ -21,9 +21,6 @@ class MPXOffsetIntersectionTestCase(TestBase):
MPX_CONFIG_REGS = ('bndcfgu', 'bndstatus')
BND_VALUE = '{' + ' '.join(('0xff' for _ in range(16))) + '}'
- def setUp(self):
- TestBase.setUp(self)
-
@skipIf(oslist=no_match(['linux']))
@skipIf(archs=no_match(['x86_64']))
def test_mpx_registers_offset_intersection(self):
diff --git a/lldb/packages/Python/lldbsuite/test/commands/target/stop-hooks/TestStopHooks.py b/lldb/packages/Python/lldbsuite/test/commands/target/stop-hooks/TestStopHooks.py
index 497f99f7dd9..64686afe627 100644
--- a/lldb/packages/Python/lldbsuite/test/commands/target/stop-hooks/TestStopHooks.py
+++ b/lldb/packages/Python/lldbsuite/test/commands/target/stop-hooks/TestStopHooks.py
@@ -24,10 +24,6 @@ class TestStopHooks(TestBase):
self.main_source_file = lldb.SBFileSpec("main.c")
self.step_out_test()
- def setUp(self):
- # Call super's setUp().
- TestBase.setUp(self)
-
def step_out_test(self):
(target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(self,
"Set a breakpoint here", self.main_source_file)
diff --git a/lldb/packages/Python/lldbsuite/test/commands/version/TestVersion.py b/lldb/packages/Python/lldbsuite/test/commands/version/TestVersion.py
index ec449fd0c39..48b46f65a78 100644
--- a/lldb/packages/Python/lldbsuite/test/commands/version/TestVersion.py
+++ b/lldb/packages/Python/lldbsuite/test/commands/version/TestVersion.py
@@ -6,9 +6,6 @@ class VersionTestCase(TestBase):
mydir = TestBase.compute_mydir(__file__)
- def setUp(self):
- TestBase.setUp(self)
-
@no_debug_info_test
def test_version(self):
# Should work even when people patch the output,
diff --git a/lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_disable/TestWatchpointDisable.py b/lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_disable/TestWatchpointDisable.py
index 3a75dfb8a68..f8dc7b3bb50 100644
--- a/lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_disable/TestWatchpointDisable.py
+++ b/lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_disable/TestWatchpointDisable.py
@@ -11,10 +11,6 @@ from lldbsuite.test import lldbplatform, lldbplatformutil
class TestWatchpointSetEnable(TestBase):
mydir = TestBase.compute_mydir(__file__)
- def setUp(self):
- # Call super's setUp().
- TestBase.setUp(self)
-
def test_disable_works (self):
"""Set a watchpoint, disable it, and make sure it doesn't get hit."""
self.build()
OpenPOWER on IntegriCloud