summaryrefslogtreecommitdiffstats
path: root/lldb/packages/Python/lldbsuite/test/commands/frame
diff options
context:
space:
mode:
authorAdrian Prantl <aprantl@apple.com>2019-09-25 00:36:00 +0000
committerAdrian Prantl <aprantl@apple.com>2019-09-25 00:36:00 +0000
commit5c4c9e61725526e1e7afca87b395a0efd2aeabfd (patch)
tree174ed56ba52ef911ec05e5f15d607a5004c34eca /lldb/packages/Python/lldbsuite/test/commands/frame
parent24f63176342dabc35582cb9e7574d288c7779272 (diff)
downloadbcm5719-llvm-5c4c9e61725526e1e7afca87b395a0efd2aeabfd.tar.gz
bcm5719-llvm-5c4c9e61725526e1e7afca87b395a0efd2aeabfd.zip
Canonicalize variable usage in testsuite Makefiles
This test streamlines our use of variables that are expected by Makefile.rules throughout the test suite. Mostly it replaced potentially dangerous overrides and updates of variables like CFLAGS with safe assignments to variables reserved for this purpose like CFLAGS_EXTRAS. Differential Revision: https://reviews.llvm.org/D67984 llvm-svn: 372795
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/commands/frame')
-rw-r--r--lldb/packages/Python/lldbsuite/test/commands/frame/recognizer/Makefile7
-rw-r--r--lldb/packages/Python/lldbsuite/test/commands/frame/var/Makefile2
2 files changed, 5 insertions, 4 deletions
diff --git a/lldb/packages/Python/lldbsuite/test/commands/frame/recognizer/Makefile b/lldb/packages/Python/lldbsuite/test/commands/frame/recognizer/Makefile
index b016328910e..8248c01fe6a 100644
--- a/lldb/packages/Python/lldbsuite/test/commands/frame/recognizer/Makefile
+++ b/lldb/packages/Python/lldbsuite/test/commands/frame/recognizer/Makefile
@@ -1,8 +1,9 @@
OBJC_SOURCES := main.m
-CFLAGS_EXTRAS += -g0 # No debug info.
+CFLAGS_EXTRAS := -g0 # No debug info.
MAKE_DSYM := NO
-include Makefile.rules
-LDFLAGS += -framework Foundation
+
+LD_EXTRAS := -framework Foundation
+include Makefile.rules
diff --git a/lldb/packages/Python/lldbsuite/test/commands/frame/var/Makefile b/lldb/packages/Python/lldbsuite/test/commands/frame/var/Makefile
index aa5f222c08e..695335e068c 100644
--- a/lldb/packages/Python/lldbsuite/test/commands/frame/var/Makefile
+++ b/lldb/packages/Python/lldbsuite/test/commands/frame/var/Makefile
@@ -1,4 +1,4 @@
C_SOURCES := main.c
-CFLAGS_EXTRAS += -std=c99
+CFLAGS_EXTRAS := -std=c99
include Makefile.rules
OpenPOWER on IntegriCloud