summaryrefslogtreecommitdiffstats
path: root/lldb/packages/Python/lldbsuite/test/commands/expression/context-object-objc
diff options
context:
space:
mode:
authorZachary Turner <zturner@google.com>2019-10-10 20:25:51 +0000
committerZachary Turner <zturner@google.com>2019-10-10 20:25:51 +0000
commit02c53868116d9bc5e76400183250772af5807eb9 (patch)
tree01a12eb996cb36e948796a336689b949e9eb800c /lldb/packages/Python/lldbsuite/test/commands/expression/context-object-objc
parent3620e8fdb554de622327362ef303a37076044f3a (diff)
downloadbcm5719-llvm-02c53868116d9bc5e76400183250772af5807eb9.tar.gz
bcm5719-llvm-02c53868116d9bc5e76400183250772af5807eb9.zip
[PDB] Fix bug when using multiple PCH header objects with the same name.
A common pattern in Windows is to have all your precompiled headers use an object named stdafx.obj. If you've got a project with many different static libs, you might use a separate PCH for each one of these. During the final link step, a file from A might reference the PCH object from A, but it will have the same name (stdafx.obj) as any other PCH from another project. The only difference will be the path. For example, A might be A/stdafx.obj while B is B/stdafx.obj. The existing algorithm checks only the filename that was passed on the command line (or stored in archive), but this is insufficient in the case where relative paths are used, because depending on the command line object file / library order, it might find the wrong PCH object first resulting in a signature mismatch. The fix here is to simply check whether the absolute path of the PCH object (which is stored in the input obj file for the file that references the PCH) *ends with* the full relative path of whatever is specified on the command line (or is in the archive). Differential Revision: https://reviews.llvm.org/D66431 llvm-svn: 374442
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/commands/expression/context-object-objc')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud