diff options
author | Calixte Denizet <calixte.denizet@gmail.com> | 2019-12-03 10:32:25 +0100 |
---|---|---|
committer | Calixte Denizet <calixte.denizet@gmail.com> | 2019-12-09 10:39:55 +0100 |
commit | 88f5bf77f92899b19fdafdffc7b060f930c1cb8b (patch) | |
tree | f88abd486ce42b9359a977ede5bfda619d9dd202 /lldb/packages/Python/lldbsuite/test/commands/expression/call-function/TestCallUserDefinedFunction.py | |
parent | f6e05672f6566a8d7efc4aed6473319e7115f979 (diff) | |
download | bcm5719-llvm-88f5bf77f92899b19fdafdffc7b060f930c1cb8b.tar.gz bcm5719-llvm-88f5bf77f92899b19fdafdffc7b060f930c1cb8b.zip |
[compiler-rt] Add a critical section when flushing gcov counters
Summary:
Counters can be flushed in a multi-threaded context for example when the process is forked in different threads (https://github.com/llvm/llvm-project/blob/master/llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp#L632-L663).
In order to avoid pretty bad things, a critical section is needed around the flush.
We had a lot of crashes in this code in Firefox CI when we switched to clang for linux ccov builds and those crashes disappeared with this patch.
Reviewers: marco-c, froydnj, dmajor, davidxl
Reviewed By: marco-c, dmajor
Subscribers: froydnj, dmajor, dberris, jfb, #sanitizers, llvm-commits, sylvestre.ledru
Tags: #sanitizers, #llvm
Differential Revision: https://reviews.llvm.org/D70910
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/commands/expression/call-function/TestCallUserDefinedFunction.py')
0 files changed, 0 insertions, 0 deletions