diff options
author | Hans Wennborg <hans@chromium.org> | 2019-10-22 22:39:01 +0200 |
---|---|---|
committer | Hans Wennborg <hans@chromium.org> | 2019-10-22 22:39:01 +0200 |
commit | 4c539e8da1b3de38a53ef3f7497f5c45a3243b61 (patch) | |
tree | 533f28edfd06af00dc8b93cdc50626db366b9318 /lldb/packages/Python/lldbsuite/test/commands/command/script/callables.py | |
parent | 1c98ff49a30b88a2601b92e8702ff2058c4fc226 (diff) | |
download | bcm5719-llvm-4c539e8da1b3de38a53ef3f7497f5c45a3243b61.tar.gz bcm5719-llvm-4c539e8da1b3de38a53ef3f7497f5c45a3243b61.zip |
Revert r374202"[ObjC generics] Fix not inheriting type bounds in categories/extensions."
This introduced new errors, see below. Reverting until that can be investigated
properly.
#import <AVFoundation/AVFoundation.h>
void f(int width, int height) {
FourCharCode best_fourcc = kCMPixelFormat_422YpCbCr8_yuvs;
NSDictionary* videoSettingsDictionary = @{
(id)kCVPixelBufferPixelFormatTypeKey : @(best_fourcc),
};
}
$ clang++ -c /tmp/a.mm
/tmp/a.mm:6:5: error: cannot initialize a parameter of type
'KeyType<NSCopying> _Nonnull const' (aka 'const id') with an rvalue
of type 'id'
(id)kCVPixelBufferPixelFormatTypeKey : @(best_fourcc),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
> When a category/extension doesn't repeat a type bound, corresponding
> type parameter is substituted with `id` when used as a type argument. As
> a result, in the added test case it was causing errors like
>
> > type argument 'T' (aka 'id') does not satisfy the bound ('id<NSCopying>') of type parameter 'T'
>
> We are already checking that type parameters should be consistent
> everywhere (see `checkTypeParamListConsistency`) and update
> `ObjCTypeParamDecl` to have correct underlying type. And when we use the
> type parameter as a method return type or a method parameter type, it is
> substituted to the bounded type. But when we use the type parameter as a
> type argument, we check `ObjCTypeParamType` that ignores the updated
> underlying type and remains `id`.
>
> Fix by desugaring `ObjCTypeParamType` to the underlying type, the same
> way we are doing with `TypedefType`.
>
> rdar://problem/54329242
>
> Reviewers: erik.pilkington, ahatanak
>
> Reviewed By: erik.pilkington
>
> Subscribers: jkorous, dexonsmith, ributzka, cfe-commits
>
> Differential Revision: https://reviews.llvm.org/D66696
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/commands/command/script/callables.py')
0 files changed, 0 insertions, 0 deletions