diff options
| author | Lawrence D'Anna <lawrence_danna@apple.com> | 2019-10-17 22:22:06 +0000 |
|---|---|---|
| committer | Lawrence D'Anna <lawrence_danna@apple.com> | 2019-10-17 22:22:06 +0000 |
| commit | c86a6acaee55c98072ff06d372d049cb4a671fb5 (patch) | |
| tree | b2300fe71c5baff776cacda3a339b35fbd2f3760 /lldb/packages/Python/lldbsuite/test/api/multithreaded/TestMultithreaded.py | |
| parent | 3d737b642a3a0688de9ed6dd3fe599bc2ed79847 (diff) | |
| download | bcm5719-llvm-c86a6acaee55c98072ff06d372d049cb4a671fb5.tar.gz bcm5719-llvm-c86a6acaee55c98072ff06d372d049cb4a671fb5.zip | |
clean up the implementation of PythonCallable::GetNumArguments
Summary:
The current implementation of PythonCallable::GetNumArguments
is not exception safe, has weird semantics, and is just plain
incorrect for some kinds of functions.
Python 3.3 introduces inspect.signature, which lets us easily
query for function signatures in a sane and documented way.
This patch leaves the old implementation in place for < 3.3,
but uses inspect.signature for modern pythons. It also leaves
the old weird semantics in place, but with FIXMEs grousing about
it. We should update the callers and fix the semantics in a
subsequent patch. It also adds some tests.
Reviewers: JDevlieghere, clayborg, labath, jingham
Reviewed By: labath
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D68995
llvm-svn: 375181
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/api/multithreaded/TestMultithreaded.py')
0 files changed, 0 insertions, 0 deletions
